Skip to content

Minds Frontend
Minds Frontend
Open
Opened by Ben Hayward@benhayward.ben
Report abuse

[Sprint/QuietQuail](fix): Blog & media edit updated to new nsfw system #1936

Closes #1936 and #2267

Depends on engine!384

Summary

This changes first part encompasses a fix to the NSFW system, wherein even though the selector shows as blue, it does not respect the values in it without clicking it, so a user may believe they are posting something as NSFW, but in actuality the post would be untagged.

The other change, moves the future blogs to the mature blog system, to the NSFW blog system. When creating a new blog, values must also be respected as in the first part of this upgrade, however, when editing, existing values must be shown.

Testing

Blog

Example testing video - https://streamable.com/ps39o

  1. Post NSFW Post, give it a few random reasons, remember them.
  2. Post a blog - do not touch the selector
  3. Edit blog, check the selector - it should be the same as your last post.
  4. Change the NSFW tags
  5. Edit again and ensure the change stuck
  6. Check the changes are respected on the channel sidebar
  1. Post a non-NSFW blog post
  2. Edit it to be NSFW, enter edit mode again to check it 3. worked
  3. Make a normal post with different tags.
  4. Edit blog and check it ignores those tags, and has the correct ones for the blog.
  1. In one of the NSFW blogs activity posts on the feed, mark it as non-nsfw
  2. Check change propegates by clicking the blog, editing, checking nothing is checked
  3. Ensure the sidebar of the blog does not have the explicit overlay now.
  1. Edit it back to be NSFW in the activity.
  2. Check the change propegated in the same fashion.
  3. Ensure blogs in sidebar are flagged appropriately
Poster

Example testing video - https://streamable.com/3r8d2

  1. Make a non-nsfw post.
  2. Edit to be nsfw.
  3. Edit again to make sure the tags stuck.
  4. Remove NSFW from the activity, check the activity is no longer nsfw.
  5. Make a new NSFW post, remember the nsfw tags you placed on it.
  6. Nav to another page like wallet and back.
  7. Post, it should be NSFW.
  8. Make another post with a different config to change the nsfw selectors defaults.
  9. On the post in step 7, edit and check the nsfw values are correct.
Media

Example testing video - https://streamable.com/qokw4

  1. Post NSFW media (remember which nsfw reasons you selected).
  2. Make another random post with another configuration of NSFW reasons.
  3. Check the activity, edit it, it should show the reasons correctly, and not show the values of your last post.
  4. Edit it to not be NSFW, this should be respected
  5. Edit it back to being NSFW.
  1. Go to the media page for the activity (if you are seeing media modals, just reload the url in the url box).
  2. NSFW values should be respected (check via edit)
  3. Edit away the changes
  4. Check changes apply to the activity on the newsfeed.
  5. Go back onto the media page.
  6. Make it NSFW again.
  7. Check changes propagate.
Admin

Example testing video - https://streamable.com/v8hye

  1. Watch XHRs
  2. Visit channel
  3. Ensure no spam calls are made to moderation endpoints
  1. Ensure an admin can set a post on another user as NSFW
  2. Ensure an NSFW post shows the correct reasons initially, regardless of what the current state of the admins NSFW post box is.

Issues I'm aware of

  • Live update of NSFW in sidebar widgets - I would prefer to leave this out of this, and add that in at a later date. With the amount of testing involved change-detection fixes are not something I want to add into the mix.

  • Image posts are not propagating to sidebar widget; handled here engine#1150 Blogs and Video should be

Edited by Ben Hayward
Request to merge fix/blog-media-nsfw-update-1936 into master
The source branch is 36 commits behind the target branch
Open in Web IDE
Pipeline #97599328 passed with warnings for 31888535 on fix/blog-media-nsfw-update-1936
              Merge request approved. Approved by
              Brian Hatchet Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1936 and #2267

              Mentions engine#1150

              Deletes source branch

              0/7 threads resolved
              Please register or sign in to reply