Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 399
  • Merge Requests 51
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !639

Closed
Opened 3 weeks ago by Marcelo Rivera@eiennohi
Report abuse

Admin cannot delete or highlight text in footer link editor

closes #2214 (closed)

we had to fork ngx-drag-drop and I added a couple of methohds that apply a drag lock, ensuring I can disable drag&drop when focusing on the inputs, and then re-enabling it when clicking on the handle on the left

Request to merge fix/cannot-highlight-text-2214 into master
Pipeline #97099145 failed for e6bf8a49 on fix/cannot-highlight-text-2214
              Requires 3 more approvals from Devs, Deployers, and QA.
              Olivia Madrid
              Olivia Madrid
              Mark Harding
              Mark Harding
              Ben Hayward
              Ben Hayward
              Juan Manuel Solaro
              Juan Manuel Solaro
              Rami Albatal
              Rami Albatal

              Closed by Mark Harding 3 hours ago

              The changes were not merged into master

              Did not close #2214 (closed)

              Deletes source branch

              • Discussion 2
              • Commits 3
              • Pipelines 5
              • Changes 6
              • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label 3 weeks ago

                added scoped label

              • Marcelo Rivera @eiennohi restored source branch fix/cannot-highlight-text-2214 3 weeks ago

                restored source branch fix/cannot-highlight-text-2214

              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 3 weeks ago

                added scoped label and automatically removed label

              • Mark Harding
                Mark Harding @markeharding · 3 weeks ago
                Owner

                Failing tests. Please keep on top of these merge requests.

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • 8d93746d - (feat): make use of the drag lock from ngx-drag-drop

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • 6ab11859 - (feat): make use of the drag lock from ngx-drag-drop

                Compare with previous version

              • Marcelo Rivera @eiennohi added 44 commits 1 week ago

                added 44 commits

                • 6ab11859...a0d1737e - 43 commits from branch master
                • f3269ee0 - Merge remote-tracking branch 'upstream/master' into fix/cannot-highlight-text-2214

                Compare with previous version

              • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 week ago

                added scoped label and automatically removed label

              • Marcelo Rivera @eiennohi added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 week ago

                added scoped label and automatically removed label

              • Marcelo Rivera @eiennohi added 1h 30m of time spent at 2019-11-19 1 week ago

                added 1h 30m of time spent at 2019-11-19

              • Marcelo Rivera @eiennohi added Sprint::11/06 - Rolling Rabbit scoped label 1 week ago

                added scoped label

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • e6bf8a49 - (fix): added in an entry for ngx-drag-drop into tsconfig.json's paths

                Compare with previous version

              • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 week ago

                added scoped label and automatically removed label

              • Marcelo Rivera
                Marcelo Rivera @eiennohi · 1 week ago
                Developer

                @markeharding just updated

              • Mark Harding @markeharding closed 3 hours ago

                closed

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              Spent: 1h 30m
              2
              Labels
              MR::Awaiting Review Sprint::11/06 - Rolling Rabbit
              Lock merge request
              Unlocked
              11
              11 participants
              user avatar
              Olivia Madrid
              user avatar
              Mark Harding
              user avatar
              Ben Hayward
              user avatar
              Juan Manuel Solaro
              user avatar
              Rami Albatal
              user avatar
              Xander Miller
              user avatar
              Emiliano Balbuena
              Reference: minds/front!639