Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 295
  • Merge Requests 38
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !407

Open
Opened 5 days ago by Emiliano Balbuena@edgebal
Report abuse

Top Algorithm

Issues

  • Closes #1144
  • Closes #1145
  • Closes #1157
  • Closes #1174
Request to merge goal/top-algorithm-redux-2 into master
The source branch is 7 commits behind the target branch
Open in Web IDE
Pipeline #98764859 passed for 129b4263 on goal/top-algorithm-redux-2
          Requires 3 more approvals from Devs, Deployers, and QA.
          Ben Hayward
          Ben Hayward
          Olivia Madrid
          Olivia Madrid
          Brian Hatchet
          Brian Hatchet
          Mark Harding
          Mark Harding
          Guy Thouret
          Guy Thouret
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1144, #1145, #1157, and #1174

          Deletes source branch

          • Discussion 2
          • Commits 3
          • Pipelines 2
          • Changes 35
          0/2 threads resolved
          • Emiliano Balbuena @edgebal changed milestone to %HILE Q4/2019 5 days ago

            changed milestone to %HILE Q4/2019

          • Emiliano Balbuena @edgebal added Squad::Yellow scoped label 5 days ago

            added scoped label

          • Emiliano Balbuena @edgebal added 1 commit 5 days ago

            added 1 commit

            • 129b4263 - (cs): Lint

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 2 hours ago
            Controllers/Cli/Top/All.php
            94 * @param $type
            95 * @param $subtype
            96 * @param $metric
            97 * @param $from
            98 * @param $to
            99 * @throws CliException
            100 * @throws Exception
            101 */
            102 protected function syncBy($type, $subtype, $metric, $from, $to)
            103 {
            104 if (!$metric) {
            105 throw new CliException('Missing --metric flag');
            106 }
            107
            108 if (!$from || !is_numeric($from)) {
            109 throw new CliException('Missing or invalid --from flag');
            • Mark Harding
              Mark Harding @markeharding · 2 hours ago
              Owner

              If this is running from a cli job, can we support something like --minsAgo or --secsAgo?

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 hour ago
            Core/Counters.php
            1 <?php
            2 /**
            3 * @author edgebal
            4 */
            5 namespace Minds\Core;
            6
            7 use Minds\Helpers\Counters as CountersHelper;
            8
            9 class Counters
            • Mark Harding
              Mark Harding @markeharding · 1 hour ago
              Owner

              Is the purpose of this to make a static an instance? If so consider using Minds\Common\StaticToInstance

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes scoped label 1 hour ago

            added scoped label

          Please register or sign in to reply
          Assignee
          Emiliano Balbuena's avatar
          Emiliano Balbuena @edgebal
          HILE Q4/2019
          Milestone
          HILE Q4/2019
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Ben Hayward
          user avatar
          Olivia Madrid
          user avatar
          Brian Hatchet
          user avatar
          Mark Harding
          user avatar
          Guy Thouret
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          Reference: minds/engine!407