Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 292
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 39
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #1115

Closed
Open
Opened 2 weeks ago by Nicholas Lewis@javanick
Report abuse New issue

0 balance being returned by v2/blockchain/wallet/balance

Summary

Many users are reporting that their tokens have disappeared from the Minds site, but are still present on Metamask.

  • https://www.minds.com/newsfeed/1039979537764175872?referrer=nemofin
  • https://www.minds.com/newsfeed/1040514369536634880?referrer=nemofin
  • https://www.minds.com/newsfeed/1040389763391864832?referrer=nemofin

Steps to reproduce

  1. Check /wallet

Platform information

Cross-platform web.

What is the current bug behavior?

Balance returned is 0

What is the expected correct behavior?

Balance returned should be 0 only if the address holds no MINDS.

Relevant logs and/or screenshots

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

/label ~"T - Bug" ~"S - Triage:new"

Edited 2 weeks ago by Ben Hayward

Related issues
0

Related merge requests
1
  • [Sprint/RollingRabbit](fix): Wallet balance caching #1115
    !396
When this merge request is accepted, this issue will be closed automatically.
  • Discussion 10
  • Designs 0
  • Nicholas Lewis @javanick added Priority::1 - High Product::Wallet Type::Bug scoped labels 2 weeks ago

    added scoped labels

  • Bill Ottman
    Bill Ottman :dragon_face: @ottman · 2 weeks ago
    Developer

    This should be labeled regression

  • Ben Hayward
    Ben Hayward @benhayward.ben · 2 weeks ago
    Developer

    Cause unknown at this moment, last time this kind of thing happened it was down to MetaMask defaulting their privacy settings to private mode.

  • Luculent
    Luculent @luculent · 2 weeks ago

    Mine are gone too

    Firefox 68.2.0 ESK/Debian Buster

    Never use Brave, and have not turned on Metamask in a while.

    Edited by Luculent 2 weeks ago
  • Fire Chief
    Fire Chief @onecrazychief · 2 weeks ago

    I'm using Windows 7 with Brave Browser Version 0.70.123 Chromium: 78.0.3904.97 (Official Build) (32-bit). I do not have MetaMask installed on this computer. My Receiver Address on Minds is:

    0x5FCBd7De4fBc2045100c4E958b2F67dbDbab18CA

    I sent ETH to that address. If you look at the blockchain explorer you can see the ETH on that address: https://etherscan.io/address/0x5FCBd7De4fBc2045100c4E958b2F67dbDbab18CA

    But, if you look at my wallet it shows the balance as "0".

    I have a feeling this could also somehow be a misunderstanding between the expected behavior of end users and the assumptions from the developers / staff of Minds. I have never taken any of my Minds token on-chain. I have 300 Minds tokens that are offchain right now. I have never purchased Minds Tokens or ETH via the Minds website. I have never set up Crypto Wallets in Brave Browser nor have I installed MetaMask. I have never purchased ETH via SendWyre or MetaMask. I purchased my ETH on Uphold.com and sent them to my receiver address on Minds: 0x5FCBd7De4fBc2045100c4E958b2F67dbDbab18CA

    Please let me know if you need more info from this system to help troubleshoot.

    Edited by Fire Chief 3 days ago
  • Ben Hayward @benhayward.ben changed title from Tokens not appearing for users to 0 balance being returned by v2/blockchain/wallet/balance 2 weeks ago

    changed title from to

  • Ben Hayward @benhayward.ben changed the description 2 weeks ago

    changed the description

  • Ben Hayward @benhayward.ben added Priority::0 - Urgent scoped label and automatically removed Priority::1 - High label 2 weeks ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben changed the description 2 weeks ago

    changed the description

  • Ben Hayward @benhayward.ben assigned to @benhayward.ben 2 weeks ago

    assigned to @benhayward.ben

  • Ben Hayward @benhayward.ben added Sprint::11/06 - Rolling Rabbit Status::InProgress scoped labels 2 weeks ago

    added scoped labels

  • Ben Hayward
    Ben Hayward @benhayward.ben · 2 weeks ago
    Developer

    So, what seems to be happening is that v2/blockchain/wallet/balance is returning a 0 when it cannot get the balance. An error should be returned instead, indicating the failure.

    It's my understanding that in the event there is a failure the token balance should be loaded by MetaMask, as it does locally. On production this is not the case. So that's a separate issue.

  • Ben Hayward @benhayward.ben mentioned in merge request !396 (merged) 2 weeks ago

    mentioned in merge request !396 (merged)

  • Ben Hayward
    Ben Hayward @benhayward.ben · 2 weeks ago
    Developer

    Proposed a solution based on Mark pointing out that we are caching the wallet balance when values are null, this is going to require some testing and likely a revision.

  • Ben Hayward @benhayward.ben changed time estimate to 5h 2 weeks ago

    changed time estimate to 5h

  • Ben Hayward @benhayward.ben added 3h of time spent at 2019-11-12 2 weeks ago

    added 3h of time spent at 2019-11-12

  • Ben Hayward @benhayward.ben added Status::Review scoped label and automatically removed Status::InProgress label 2 weeks ago

    added scoped label and automatically removed label

  • Fire Chief
    Fire Chief @onecrazychief · 1 week ago

    @benhayward.ben wrote:

    It's my understanding that in the event there is a failure the token balance should be loaded by MetaMask, as it does locally.

    What if you don't use MetaMask? I sent my ETH directly to my receiver address. Shouldn't my wallet be showing the ETH balance of any ETH sent to that address?

    Receiver Address = 0x5FCBd7De4fBc2045100c4E958b2F67dbDbab18CA

  • Ben Hayward
    Ben Hayward @benhayward.ben · 1 week ago
    Developer

    Hi @onecrazychief, yes that should also be showing up, it's our blockchain API endpoint failing.

  • Mark Harding @markeharding closed via merge request !396 (merged) 1 week ago

    closed via merge request !396 (merged)

  • Mark Harding @markeharding mentioned in commit 52a592b9 1 week ago

    mentioned in commit 52a592b9

  • Ben Hayward @benhayward.ben mentioned in commit 41bb431c 1 week ago

    mentioned in commit 41bb431c

  • Ben Hayward @benhayward.ben reopened 5 days ago

    reopened

  • Ben Hayward
    Ben Hayward @benhayward.ben · 5 days ago
    Developer

    Issue still persists @markeharding

  • Ben Hayward @benhayward.ben added Sprint::11/20 - Silly Sheep scoped label and automatically removed Sprint::11/06 - Rolling Rabbit label 5 days ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben unassigned @benhayward.ben 5 days ago

    unassigned @benhayward.ben

  • Ben Hayward @benhayward.ben added Status::Backlog scoped label and automatically removed Status::Review label 4 days ago

    added scoped label and automatically removed label

  • Fire Chief
    Fire Chief @onecrazychief · 20 minutes ago

    tenor

Please register or sign in to reply
0 Assignees
None
none
Epic
None
None
Milestone
None
Time tracking
Spent 3h
Est 5h
None
Due date
None
5
Labels
Priority::0 - Urgent Product::Wallet Sprint::11/20 - Silly Sheep Status::Backlog Type::Bug
None
Weight
None
Confidentiality
Not confidential
Lock issue
Unlocked
6
6 participants
user avatar
Fire Chief
user avatar
Luculent
user avatar
Bill Ottman
user avatar
Ben Hayward
user avatar
Mark Harding
user avatar
Nicholas Lewis
Reference: minds/engine#1115