Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project overview
  • Repository
  • Issues 177
  • Merge Requests 12
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !425

Merged
Opened 1 day ago by Martin Santangelo@msantang78
Report abuse

Fix android font weight ignore >= 700

This was caused by a RN >= 0.60 issue with the font-weight
I fixed all the occurrences of fontWeight: '800' of the app

closes #1537

Edited 1 day ago by Martin Santangelo
Request to merge fix/android-font-weight-greather-than-700 into release/3.12.0
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Merge request approved. Approved by
Juan Manuel Solaro
Juan Manuel Solaro
Brian Hatchet
Brian Hatchet

Merged by Martin Santangelo 17 minutes ago

The changes were merged into release/3.12.0 with b45d304d

Pipeline #98748044 running for b45d304d on release/3.12.0
        • Discussion 2
        • Commits 2
        • Pipelines 3
        • Changes 15
        0/1 thread resolved
        • Martin Santangelo @msantang78 changed milestone to %Mobile 3.12 1 day ago

          changed milestone to %Mobile 3.12

        • Martin Santangelo @msantang78 added MR::Awaiting Review Platform::Mobile::Android Squad::Green scoped labels 1 day ago

          added scoped labels

        • Martin Santangelo @msantang78 changed the description 1 day ago

          changed the description

        • Martin Santangelo @msantang78 added 1 commit 1 day ago

          added 1 commit

          • 1649379c - (fix) android font weight ignore >= 700

          Compare with previous version

        • Brian Hatchet
          Brian Hatchet :speech_balloon: @brianhatchet started a thread on an old version of the diff 21 hours ago
          Last updated by Martin Santangelo 21 hours ago
          src/styles/Common.js
          567 568 paddingBottom: 10,
          568 569 },
          569 570 modalTitle: {
          570 fontWeight: '800',
          571 fontWeight: '700',
          • Brian Hatchet
            Brian Hatchet :speech_balloon: @brianhatchet · 21 hours ago
            Developer

            Some times we're changing the fontWeight, sometimes we're commenting in favor of Fontfamily. What's the difference?

          • Martin Santangelo
            Martin Santangelo @msantang78 · 21 hours ago
            Developer

            I should change the font there too, my first approach was to change the weight to 700 but is not the same, it will be slimmer font than the 800.
            I will fix it

          • Martin Santangelo @msantang78 changed this line in version 3 of the diff 21 hours ago

            changed this line in version 3 of the diff

          • Please register or sign in to reply
        • Martin Santangelo @msantang78 added 1 commit 21 hours ago

          added 1 commit

          • 86cc3c78 - (fix) common style modal title bold

          Compare with previous version

        • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 28 minutes ago

          approved this merge request

        • Juan Manuel Solaro @juanmsolaro approved this merge request 26 minutes ago

          approved this merge request

        • Martin Santangelo @msantang78 merged 17 minutes ago

          merged

        • Martin Santangelo @msantang78 mentioned in commit b45d304d 17 minutes ago

          mentioned in commit b45d304d

        Please register or sign in to reply
        0 Assignees
        None
        Mobile 3.12
        Milestone
        Mobile 3.12
        Time tracking
        No estimate or time spent
        3
        Labels
        MR::Awaiting Review Platform::Mobile::Android Squad::Green
        Lock merge request
        Unlocked
        3
        3 participants
        user avatar
        Martin Santangelo
        user avatar
        Juan Manuel Solaro
        user avatar
        Brian Hatchet
        Reference: minds/mobile-native!425