Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project overview
  • Repository
  • Issues 174
  • Merge Requests 13
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !425

Open
Opened 8 hours ago by Martin Santangelo@msantang78
Report abuse

Fix android font weight ignore >= 700

This was caused by a RN >= 0.60 issue with the font-weight
I fixed all the occurrences of fontWeight: '800' of the app

closes #1537

Edited 8 hours ago by Martin Santangelo
Request to merge fix/android-font-weight-greather-than-700 into release/3.12.0
Open in Web IDE
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Requires 2 more approvals.
Ready to be merged automatically. Ask someone with write access to this repository to merge this request
  • Discussion 2
  • Commits 2
  • Pipelines 3
  • Changes 15
0/1 thread resolved
  • Martin Santangelo @msantang78 changed milestone to %Mobile 3.12 8 hours ago

    changed milestone to %Mobile 3.12

  • Martin Santangelo @msantang78 added MR::Awaiting Review Platform::Mobile::Android Squad::Green scoped labels 8 hours ago

    added scoped labels

  • Martin Santangelo @msantang78 changed the description 8 hours ago

    changed the description

  • Martin Santangelo @msantang78 added 1 commit 7 hours ago

    added 1 commit

    • 1649379c - (fix) android font weight ignore >= 700

    Compare with previous version

  • Brian Hatchet
    Brian Hatchet :speech_balloon: @brianhatchet started a thread on an old version of the diff 1 hour ago
    Last updated by Martin Santangelo 1 hour ago
    src/styles/Common.js
    567 568 paddingBottom: 10,
    568 569 },
    569 570 modalTitle: {
    570 fontWeight: '800',
    571 fontWeight: '700',
    • Brian Hatchet
      Brian Hatchet :speech_balloon: @brianhatchet · 1 hour ago
      Developer

      Some times we're changing the fontWeight, sometimes we're commenting in favor of Fontfamily. What's the difference?

    • Martin Santangelo
      Martin Santangelo @msantang78 · 1 hour ago
      Developer

      I should change the font there too, my first approach was to change the weight to 700 but is not the same, it will be slimmer font than the 800.
      I will fix it

    • Martin Santangelo @msantang78 changed this line in version 3 of the diff 1 hour ago

      changed this line in version 3 of the diff

    • Please register or sign in to reply
  • Martin Santangelo @msantang78 added 1 commit 1 hour ago

    added 1 commit

    • 86cc3c78 - (fix) common style modal title bold

    Compare with previous version

Please register or sign in to reply
0 Assignees
None
Mobile 3.12
Milestone
Mobile 3.12
Time tracking
No estimate or time spent
3
Labels
MR::Awaiting Review Platform::Mobile::Android Squad::Green
Lock merge request
Unlocked
2
2 participants
user avatar
Martin Santangelo
user avatar
Brian Hatchet
Reference: minds/mobile-native!425