Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 400
  • Merge Requests 56
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !623

Open
Opened 3 weeks ago by Marcelo Rivera@eiennohi
Report abuse

Homepage redesign

closes https://gitlab.com/minds/ux/issues/2 closes #2112

Testing

  • logged out, go to the homepage. There's a 50/50 chance that you will either see a mobile phone on the right, or the register form. You can change it manually by modifying the experiment key in the local storage from 'base' to 'form' and vice-versa.
  • everything should look like in Michael's designs, for mobile, tablets and desktop.

If you're on the homepage version with the mobile phone:

  • "Join Minds Now" buttons should redirect to /onboarding where you'll only see the registration form.
  • Registering should go to the next step for onboarding
  • Skipping this should redirect you to homepage

If you're on the homepage version with the register form:

  • Registering should redirect to the first step of the onboarding
  • Skipping it should redirect to newsfeed

Testing the onboarding steps TBD

depends on engine!395

Edited 3 days ago by Marcelo Rivera
Request to merge feat/homepage-redesign into master
The source branch is 1 commit behind the target branch
Open in Web IDE
Pipeline #98459842 running for fd2de775 on feat/homepage-redesign
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding
              Mark Harding
              Guy Thouret
              Guy Thouret
              Martin Santangelo
              Martin Santangelo
              Ben Hayward
              Ben Hayward
              Rami Albatal
              Rami Albatal
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2112

              Deletes source branch

              • Discussion 32
              • Commits 65
              • Pipelines 27
              • Changes 36
              10/11 threads resolved
              • Marcelo Rivera @eiennohi added Squad::Yellow scoped label 3 weeks ago

                added scoped label

              • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                added 1 commit

                • b1936251 - (fix): fixed citation alignment

                Compare with previous version

              • Marcelo Rivera @eiennohi changed the description 3 weeks ago

                changed the description

              • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                added 1 commit

                • 71354415 - (feat): update topbar design

                Compare with previous version

              • Marcelo Rivera @eiennohi added 7 commits 1 week ago

                added 7 commits

                • 4c3d6e23 - (feat): renamed HomepageComponent to HomepageV1Component
                • 5be586b4 - (fix): no background colour for the form
                • 8484f94e - (feat): responsive design for register form and top-left corner decoration
                • 867ec072 - (fix): several styling fixes for mobile resolution
                • 2afc5b4f - (fix): app buttons
                • 11be027c - (feat): added m-grid__column__skip-#{$i} for desktop and mobile
                • 507c3221 - (fix): quotation and links styling fixes

                Compare with previous version

                Toggle commit list
              • Marcelo Rivera @eiennohi added 74 commits 1 week ago

                added 74 commits

                • 507c3221...35070b4f - 73 commits from branch master
                • cc521451 - Merge remote-tracking branch 'upstream/master' into feat/homepage-redesign

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • bd99718e - (fix): added images that got deleted while merging master

                Compare with previous version

              • Marcelo Rivera @eiennohi added 3 commits 1 week ago

                added 3 commits

                • f8ab05ee - (feat): add more margin-top to as featured in
                • 7c4044f3 - (fix): stylings for gray thingy in the first panel
                • 0287f55e - (feat): merge designs

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • 69174e34 - (feat): merge designs

                Compare with previous version

              • Marcelo Rivera @eiennohi mentioned in merge request engine!395 1 week ago

                mentioned in merge request engine!395

              • Marcelo Rivera @eiennohi unmarked as a Work In Progress 1 week ago

                unmarked as a Work In Progress

              • Marcelo Rivera @eiennohi changed title from WIP: New homepage design to Homepage redesign 1 week ago

                changed title from design to design

              • Marcelo Rivera @eiennohi changed the description 1 week ago

                changed the description

              • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label 1 week ago

                added scoped label

              • Marcelo Rivera @eiennohi marked as a Work In Progress 1 week ago

                marked as a Work In Progress

              • Marcelo Rivera @eiennohi added 2 commits 1 week ago

                added 2 commits

                • 9e1a8a28 - (fix): layout tweaks
                • 701bc989 - (feat): stylings for tablets

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • ecd06913 - (feat): stylings for tablets

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                added 1 commit

                • dec3617e - (feat): stylings for tablets

                Compare with previous version

              • Marcelo Rivera @eiennohi added 11 commits 1 week ago

                added 11 commits

                • dec3617e...a0d1737e - 10 commits from branch master
                • 57e73e13 - Merge remote-tracking branch 'upstream/master' into feat/homepage-redesign

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 6 days ago

                added 1 commit

                • 18ccfa82 - (feat): popover for password validation

                Compare with previous version

              • Marcelo Rivera @eiennohi changed the description 6 days ago

                changed the description

              • Marcelo Rivera @eiennohi added 17 commits 3 days ago

                added 17 commits

                • 18ccfa82...32c47ab2 - 13 commits from branch master
                • 76833369 - (feat): remove last section and correct items in "our principles"
                • fb30ca6f - (feat): add join button
                • dbe902ab - (fix): tringle thingy
                • 011c75d7 - Merge remote-tracking branch 'upstream/master' into feat/homepage-redesign

                Compare with previous version

                Toggle commit list
              • Marcelo Rivera @eiennohi added 1 commit 3 days ago

                added 1 commit

                • 19edd595 - (fix): lint

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 3 days ago

                added 1 commit

                • 3607b826 - (fix): "Join Minds Now" on the bottom should only appear for base experiment

                Compare with previous version

              • Marcelo Rivera @eiennohi unmarked as a Work In Progress 3 days ago

                unmarked as a Work In Progress

              • Marcelo Rivera @eiennohi added 3 commits 3 days ago

                added 3 commits

                • fafb747d - (feat): add in support for multiple experiments in a single element
                • e1930348 - (feat): added in new homepage experiments
                • 1afe3d6f - (fix): spec tests and types

                Compare with previous version

                • Bill Ottman
                  Bill Ottman :dragon_face: @ottman · 2 days ago
                  Reporter

                  Link? ;)

                • Collapse replies
                • Mark Harding
                  Mark Harding @markeharding · 1 day ago
                  Owner

                  Click 'View App' above. Screen_Shot_2019-11-24_at_3.41.15_AM

                • Please register or sign in to reply
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 day ago
                Resolved by Marcelo Rivera 1 hour ago
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 1 day ago
                Resolved by Marcelo Rivera 1 hour ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 day ago
                Resolved by Mark Harding 9 hours ago
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 1 day ago
                Resolved by Marcelo Rivera 1 hour ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 day ago
                Resolved by Mark Harding 9 hours ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 day ago
                Resolved by Marcelo Rivera 23 hours ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 day ago
                Resolved by Marcelo Rivera 23 hours ago
              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 day ago
                Resolved by Marcelo Rivera 1 hour ago
              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 1 day ago
                Resolved by Marcelo Rivera 23 hours ago
                • Mark Harding
                  Mark Harding @markeharding · 1 day ago
                  Owner
                  Resolved by Marcelo Rivera 1 hour ago

                  @michaelfbradley Why are we using a different green on the homepage to elsewhere?

                • Michael Bradley
                  Michael Bradley
                  Mark Harding
                  Mark Harding
                  Last reply by Mark Harding 9 hours ago
              • Mark Harding
                Mark Harding @markeharding · 1 day ago
                Owner

                @eiennohi there looks to be lots of discrepancies between implementation and mockup. Also the AB testing does not appear to be working at all. Please revert those changes.

              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 day ago

                added scoped label and automatically removed label

              • Marcelo Rivera @eiennohi added 1 commit 1 day ago

                added 1 commit

                • 3f3f6fb9 - (fix): reverted latest experiment changes

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 1 day ago

                added 1 commit

                • 09e8059c - (fix): reverted lint on tasks/extract.i18n.xlf.ts

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 23 hours ago

                added 1 commit

                • 2d72a854 - (fix): use old minds-form-register

                Compare with previous version

              • Marcelo Rivera @eiennohi added 1 commit 23 hours ago

                added 1 commit

                • c8d26f1c - (fix): don't use document for accessing the topbar

                Compare with previous version

              • Mark Harding
                Mark Harding @markeharding · 9 hours ago
                Owner

                The topbar is not consistent with the mockups either and appears unfinished. Screenshot_2019-11-25_at_09.53.14. Also the margins of the bulb and the signups buttons appear to be off.

                Edited by Mark Harding 9 hours ago
              • Mark Harding
                Mark Harding @markeharding · 9 hours ago
                Owner

                I am unable to get the A/B testing platform to work without a manual override of the local storage. Does it work for you @eiennohi ?

                Screenshot_2019-11-25_at_10.01.28

                Screenshot_2019-11-25_at_10.01.19.

                There is a major discrepancy between this form and the one in mockup. These need to be pixel perfect.

                Edited by Mark Harding 9 hours ago
              • Mark Harding
                Mark Harding @markeharding · 9 hours ago
                Owner

                Form is not responsive Screenshot_2019-11-25_at_10.22.29

              • Marcelo Rivera @eiennohi mentioned in issue #2286 2 hours ago

                mentioned in issue #2286

              • Marcelo Rivera @eiennohi added 3 commits 18 minutes ago

                added 3 commits

                • 8e5f719a - (fix): register form
                • 505830c2 - (fix): update download app buttons
                • 2a65381c - (fix): re-exported cellphone image

                Compare with previous version

              • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 16 minutes ago

                added scoped label and automatically removed label

              • Marcelo Rivera @eiennohi added 1 commit 16 minutes ago

                added 1 commit

                • fd2de775 - (fix): re-exported cellphone image

                Compare with previous version

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Lock merge request
              Unlocked
              14
              14 participants
              user avatar
              Mark Harding
              user avatar
              Guy Thouret
              user avatar
              Martin Santangelo
              user avatar
              Ben Hayward
              user avatar
              Rami Albatal
              user avatar
              Xander Miller
              user avatar
              Emiliano Balbuena
              Reference: minds/front!623