Commit 3f3f6fb9 authored by Marcelo Rivera's avatar Marcelo Rivera

(fix): reverted latest experiment changes

1 merge request!623Homepage redesign
Pipeline #98191955 running with stages
......@@ -17,11 +17,11 @@ import { Storage } from '../../services/storage';
@Component({
template: `
<div
*mExperiment="'homepage'; buckets: ['base']"
*mExperiment="'homepage'; bucket: 'base'"
class="homepage-bucket-base"
></div>
<div
*mExperiment="'homepage'; buckets: ['variant1']"
*mExperiment="'homepage'; bucket: 'variant1'"
class="homepage-bucket-variant1"
></div>
`,
......
......@@ -14,7 +14,7 @@ import { ExperimentsService } from './experiments.service';
})
export class ExperimentDirective {
@Input('mExperiment') mExperimentId;
@Input() mExperimentBuckets: Array<string>;
@Input() mExperimentBucket;
constructor(
private _service: ExperimentsService,
......@@ -23,13 +23,14 @@ export class ExperimentDirective {
) {}
async ngOnInit() {
if (this.mExperimentBuckets.indexOf('base') !== -1)
this._viewContainer.createEmbeddedView(this._templateRef); // load the base first
if (this.mExperimentBucket === 'base')
//load the base first
this._viewContainer.createEmbeddedView(this._templateRef);
if (
await this._service.shouldRender({
experimentId: this.mExperimentId,
bucketIds: this.mExperimentBuckets,
bucketId: this.mExperimentBucket,
})
) {
console.log('clearing');
......
......@@ -5,7 +5,7 @@ import { Storage } from '../../services/storage';
type ExperimentBucket = {
experimentId: string;
bucketIds: Array<string>;
bucketId: string;
};
@Injectable()
......@@ -30,7 +30,7 @@ export class ExperimentsService {
let bucket = this.experiments[opts.experimentId];
if (bucket) {
return opts.bucketIds.indexOf(bucket) !== -1;
return bucket === opts.bucketId;
}
if (this.fetching) {
......@@ -40,7 +40,7 @@ export class ExperimentsService {
try {
this.fetching = true;
const response: any = await this.client.get(
let response: any = await this.client.get(
`api/v2/experiments/${opts.experimentId}`
);
bucket = response.bucketId;
......@@ -52,6 +52,6 @@ export class ExperimentsService {
this.storage.set(`experiments:${opts.experimentId}`, bucket);
this.fetching = false;
return opts.bucketIds.indexOf(bucket) !== -1;
return bucket === opts.bucketId;
}
}
......@@ -8,47 +8,18 @@
>
<h1 i18n>Minds <span class="m-homepage__yellowLine"></span></h1>
<h2
ngPreserveWhitespaces
*mExperiment="'Homepage121119'; buckets: ['base', 'form']"
i18n
>
<h2 ngPreserveWhitespaces i18n>
Earn for your ideas
</h2>
<h2
ngPreserveWhitespaces
*mExperiment="
'Homepage121119';
buckets: ['base-take-back-control', 'form-take-back-control']
"
i18n
>
Take back control of your social media
</h2>
<p class="m-marketing__description" i18n>
Free your mind and get paid for creating content, driving traffic and
referring friends. A place to have open conversations and bring people
together.
</p>
<p
class="m-marketing__description"
*mExperiment="'Homepage121119'; buckets: ['base', 'form']"
i18n
>
<p class="m-marketing__description" i18n>
Take back control of your social media.
</p>
<p
class="m-marketing__description"
*mExperiment="
'Homepage121119';
buckets: ['base-take-back-control', 'form-take-back-control']
"
i18n
>
Earn for your ideas.
</p>
<button
class="mf-button mf-button--alt m-homepage__joinButton"
......@@ -77,10 +48,7 @@
<div
class="m-grid__column-5 m-grid__column-5--tablet m-grid__column-12--mobile m-marketing__image"
*mExperiment="
'Homepage121119';
buckets: ['base', 'base-take-back-control']
"
*mExperiment="'Homepage121119'; bucket: 'base'"
>
<span>
<img
......@@ -92,10 +60,7 @@
<div
class="m-grid__column-5 m-grid__column-12--mobile"
*mExperiment="
'Homepage121119';
buckets: ['form', 'form-take-back-control']
"
*mExperiment="'Homepage121119'; bucket: 'form'"
>
<m-homepage__registerForm></m-homepage__registerForm>
</div>
......@@ -220,10 +185,7 @@
<div
class="m-marketing__section m-marketing__section--tail"
*mExperiment="
'Homepage121119';
buckets: ['base', 'base-take-back-control']
"
*mExperiment="'Homepage121119'; bucket: 'base'"
>
<div class="m-grid m-marketing__wrapper">
<div class="m-grid__column-12 m-marketing__body">
......
Please register or to comment