Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 402
  • Merge Requests 55
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !662

Open
Opened 1 day ago by Olivia Madrid@omadrid
Report abuse

Generic dropdown component

Closes #2209 (closed).

Component works the same as before, but now it is ready to be reused in wallet redesign.

Request to merge generic-dropdown-2209 into master
The source branch is 11 commits behind the target branch
Open in Web IDE
Pipeline #97746670 running for 14fa8c1b on generic-dropdown-2209
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena
              Emiliano Balbuena
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              There are merge conflicts. Resolve these conflicts or ask someone with write access to this repository to merge it locally

              Closes #2209 (closed)

              You can merge this merge request manually using the
              • Discussion 2
              • Commits 3
              • Pipelines 3
              • Changes 13
              0/1 thread resolved
              • Olivia Madrid @omadrid changed milestone to %Pro Beta #release 1 day ago

                changed milestone to %Pro Beta #release

              • Olivia Madrid @omadrid added MR::Awaiting Review Platform::Browser Priority::2 - Normal Product::Pro Squad::Blue Type::Refactor scoped labels 1 day ago

                added scoped labels

                • Mark Harding
                  Mark Harding @markeharding · 17 hours ago
                  Owner

                  Failing tests here.

                  Also, maybe we should rename to 'dropdown-selector' following our conversation yesterday?

                • Collapse replies
                • Olivia Madrid
                  Olivia Madrid @omadrid · 8 minutes ago
                  Developer

                  Didn't see this comment til after I pushed just now and had renamed it to 'm-filter'. Let me know if you want me to rename it to 'm-dropdownSelector'.

                  Is there anywhere on GitLab that would notify me that you made this comment? I'm missing all of these comments about my MRs and my 'To-Do' list is just full of "someone named you as an approver...".

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 17 hours ago

                added scoped label and automatically removed label

              • Olivia Madrid @omadrid added 1 commit 35 minutes ago

                added 1 commit

                • 14fa8c1b - (refactor): change dropdownv2 to filter and pass tests

                Compare with previous version

              Please register or sign in to reply
              0 Assignees
              None
              Pro Beta #release
              Milestone
              Pro Beta #release
              Time tracking
              No estimate or time spent
              6
              Labels
              MR::Requires Changes Platform::Browser Priority::2 - Normal Product::Pro Squad::Blue Type::Refactor
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Ben Hayward
              user avatar
              Emiliano Balbuena
              user avatar
              Guy Thouret
              user avatar
              Marcelo Rivera
              user avatar
              Mark Harding
              user avatar
              Brian Hatchet
              user avatar
              Martin Santangelo
              Reference: minds/front!662