Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 401
  • Merge Requests 52
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !652

Merged
Opened 1 week ago by Emiliano Balbuena@edgebal
Report abuse

(feat): Withdrawal status support

Check engine!393 (merged) for details.

Issues

  • Closes #2238 (closed)
  • Closes #2239 (closed)
  • Related to engine#1097 (closed)
Edited 1 week ago by Emiliano Balbuena
Request to merge goal/withdrawals-approval into master
Pipeline #97004525 passed with warnings for c065fa15 on goal/withdrawals-approval
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              All merge request dependencies have been merged (1 merged)

              Merged by Mark Harding 1 hour ago

              The changes were merged into master with 47aef7e7

              The source branch has been deleted

              Closed #2238 (closed) and #2239 (closed)

              Mentions engine#1097 (closed)

              Pipeline #97521394 running for 47aef7e7 on master
                            • Discussion 2
                            • Commits 7
                            • Pipelines 7
                            • Changes 7
                            • Emiliano Balbuena @edgebal added Product::Wallet Squad::Yellow scoped labels 1 week ago

                              added scoped labels

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • 6e151fc9 - (feat): Admin Withdrawals console

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 8 commits 1 week ago

                              added 8 commits

                              • 6e151fc9...422d7d5f - 7 commits from branch master
                              • ef3e7658 - Merge remote-tracking branch 'origin/master' into goal/withdrawals-approval

                              Compare with previous version

                            • Emiliano Balbuena @edgebal unmarked as a Work In Progress 1 week ago

                              unmarked as a Work In Progress

                            • Emiliano Balbuena @edgebal changed the description 1 week ago

                              changed the description

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • 41650ade - (feat): Spinner while doing admin withdrawal operations

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 1 week ago

                              added 1 commit

                              • ef64adba - (fix): Styling and language

                              Compare with previous version

                            • Emiliano Balbuena @edgebal changed the description 1 week ago

                              changed the description

                            • Emiliano Balbuena @edgebal added MR::Awaiting Review scoped label 5 days ago

                              added scoped label

                            • Mark Harding
                              Mark Harding @markeharding · 2 days ago
                              Owner

                              Working well for me. Found a couple issues:

                              • List still says pending despite being rejected. UI should reflect new status field. Screenshot_2019-11-18_at_14.32.03

                              Screenshot_2019-11-18_at_14.31.58

                              • Change "Withdrawals may take a few hours to complete. " to "Withdrawals may take up to 72 hours to complete."
                            • Emiliano Balbuena @edgebal added 9 commits 1 day ago

                              added 9 commits

                              • ef64adba...a0d1737e - 8 commits from branch master
                              • 4fb6726a - Merge remote-tracking branch 'origin/master' into goal/withdrawals-approval

                              Compare with previous version

                            • Emiliano Balbuena
                              Emiliano Balbuena @edgebal · 1 day ago
                              Developer

                              @markeharding Can you confirm the frontend was compiled correctly on your end? Status looks good on my end. Your screenshot seems to have the old PENDING string that was hardcoded when .completed === false. Please let me know, thanks!

                              image

                              image

                            • Emiliano Balbuena @edgebal added 1 commit 1 day ago

                              added 1 commit

                              • c065fa15 - (chore): Change withdrawal form notice language

                              Compare with previous version

                            • Mark Harding @markeharding approved this merge request 1 hour ago

                              approved this merge request

                            • Mark Harding @markeharding mentioned in commit 47aef7e7 1 hour ago

                              mentioned in commit 47aef7e7

                            • Mark Harding @markeharding merged 1 hour ago

                              merged

                            Please register or sign in to reply
                            Assignee
                            Emiliano Balbuena's avatar
                            Emiliano Balbuena @edgebal
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            3
                            Labels
                            MR::Awaiting Review Product::Wallet Squad::Yellow
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Martin Santangelo
                            user avatar
                            Ben Hayward
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Guy Thouret
                            user avatar
                            Brian Hatchet
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Olivia Madrid
                            Reference: minds/front!652