Testing

• Log out on Minds
• Visit any Pro Domain site (standalone) - user should be logged out
• Visit Minds
• Log in on Minds
• Visit any Pro Domain site - user should be logged in
• Log out on the Pro Domain site
• Visit Minds - user should be logged out
• Visit any Pro Domain site
• Log in on Pro Domain site
• Visit Minds - user should be logged in

Note: This testing procedure is valid on browsers with 3rd-party cookies enabled. On other strict-security browsers (such as Brave), Minds and Pro Domain sessions are completely independent.

Sandbox

• Minds: https://goal-pro-sso.minds.io/
• Pro Domain: http://another-domain-goal-pro-sso.minds.io

Helm Chart (Sandbox deployment chart)

• Check out this branch: https://gitlab.com/minds/helm-charts/tree/goal/pro-sso
• Manually deploy: helm upgrade --install --reuse-values --recreate-pods --set features.pro=true --set jwtsecret="<something random here>" --wait goal-pro-sso ./minds/

Issues

• Closes #1127 (closed)

added scoped label

assigned to @edgebal

added 3 commits

• aacc7678...cc738264 - 2 commits from branch master
• cd9a4013 - Merge remote-tracking branch 'origin/master' into goal/pro-sso

Compare with previous version

added 1 commit

• 3de850e7 - (feat): SSO

Compare with previous version

added 2 commits

• f74f5014 - (chore): Remove unused things
• 1f14506e - (fix): 500 when no Session

Compare with previous version

added 1 commit

• e4e5e0ea - (feat): Destroy SSO key after use

Compare with previous version

added 3 commits

• e4e5e0ea...d592fd9d - 2 commits from branch master
• c2c95dfd - Merge remote-tracking branch 'origin/master' into goal/pro-sso

Compare with previous version

added 1 commit

• ef3d7433 - (chore): Allow SSO from root domains

Compare with previous version

added 1 commit

• 1155faab - (feat): Domain enforce; (test): Spec test

Compare with previous version

unmarked as a Work In Progress

added scoped label

mentioned in merge request front!656

changed the description

mentioned in issue #961

mentioned in issue front#2236 (closed)

added 13 commits

• 1155faab...52a592b9 - 11 commits from branch master
• d9f6f766 - (chore): Pro Delegate types
• cf4c1059 - Merge remote-tracking branch 'origin/master' into goal/pro-sso

Compare with previous version

added 1 commit

• fd91559b - (fix): Origin's scheme should have more relevance for CORS

Compare with previous version

added 1 commit

• 552ccf2f - (chore): Log authorization exceptions

Compare with previous version

added 1 commit

• 3ad92c52 - (fix): Use Origin for SSO authorize

Compare with previous version

changed the description

approved this merge request

I tested on Chrome and Brave. I actually found that the system work just as well on Brave as it did on Chrome even with the shield turned on.

http://another-domain-goal-pro-sso.minds.io https://goal-pro-sso.minds.io/

I'm guessing that Brave shield might be smart enough to detect that both domains are minds.io but I'm not sure what's going on.

added scoped label and automatically removed label

added 2 commits

• 2dd9da6b - (fix): Constant typo
• c1c6569a - (refactor): Domain check to Manager

Compare with previous version

resolved all threads

added scoped label and automatically removed label

Tested again. Still good.

approved this merge request

approved this merge request

merged

mentioned in commit bf751573