Refactor PRO settings
How to test
From a non-admin
- Go to
https://eggman.minds.com - Login with a channel that has Minds Pro enable
- Navigate to the pro settings via the channel page or the settings console
- Change settings, avatars, backgrounds and confirm they save
From an admin
- Repeat the steps above from an admin account, but go to someone elses channel instead.
changed milestone to %Pro Beta #release
added scoped labels
added 42 commits
-
767c36c4...422d7d5f - 40 commits from branch
master - dfff4916 - (refactor): form toaster
- d47cd260 - Merge branch 'master' of gitlab.com:minds/front into pro-settings-2163
-
767c36c4...422d7d5f - 40 commits from branch
unmarked as a Work In Progress
assigned to @xander-miller, @jotto141, and @ottman
added scoped label
changed the description
added 6 commits
-
36499dfe...cb6d9921 - 4 commits from branch
master - 76c5db04 - Merge branch 'master' of gitlab.com:minds/front into pro-settings-2163
- eba84d39 - (feat): implement payout methods for pro
-
36499dfe...cb6d9921 - 4 commits from branch
added 1 commit
- 57c998dd - (fix): logo showing cached version post upload
approved this merge request
![Xander Miller](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="80" height="80"><rect fill-opacity="0"/></svg>)
DeveloperI found some minor issues that I reported but functionality is sound.
added 1 commit
- 16f1375c - (refactor): sidebar menu is now only populated with a menu object as input
![Bill Ottman](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
OwnerTime aspect ratio buttons on mobile web a bit off.
Edited by Bill Ottman- Developer
Apparently this a Brave specific issue. #2249
- Owner
After changing logo and banner, it saved, but reverted to my old logo and avatar. Then I refreshed and the new ones appeared, having uploaded succesfully. https://bill.minds.com
OwnerI did a fix for this that busts the cache and I couldn't replicate it again. Can you copy image source link before and after so we can compare? (@ottman)
- Owner
It worked for me this time, but maybe @xander-miller should try from a fresh account.
- Developer
I recall seeing this earlier too but I didn't report because I couldn't replicate. Also as you say, on reload it was clear it was working. It is working consistently for me now with different browsers. Animated gifs look ugly if selected for logo or background but they don't break anything.
- Owner
@markeharding I commented some issues(not sure why no one else found what I found as it is the most basic failure for this test), but unsure if that's how you'd prefer this to be done. Not sure about what to in the future when there are no more issues.
Also, a little bit confused about the blue and greens. I think we need to pick one
approved this merge request
- Developer
@markeharding Whoops I didn't see all of these comments and approvals before I pushed latest. Please disregard these last 2 commits and I'll just open a new MR for them here: !661 (closed)
Edited by Olivia Madrid added 2 commits
approved this merge request
enabled an automatic merge when the pipeline for 2de8261d succeeds
aborted the automatic merge because source branch was updated
approved this merge request
merged
mentioned in commit e239f3a9
![:dragon_face:](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="64" height="64"><rect fill-opacity="0"/></svg> ":dragon_face:"){kind=small}
