Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 301
  • Merge Requests 38
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !374

Open
Opened 1 month ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/PinkPanther](fix): Delete activity after moderation queue rejection #504

Closes #504

Summary

On production right now, if you reject a post in a group you moderate, the post no longer appears in the queue, but still shows up in the feed for mods only like so:

image

Testing

  1. Make a group, make it moderated.
  2. Login to a secondary account, create posts numbered 1, 2, 3, 4, 5.
  3. Log-in to primary account, look at the group, see the posts with "awaiting moderation"
  4. Go to the moderation queue and reject the post numbered 3.
  5. Check that the activity with the content '3' is not visible on the feed with its "awaiting moderation"
Request to merge fix/delete-activity-mod-queue-504 into master
Open in Web IDE
Pipeline #97038840 passed for 5d25f8fe on fix/delete-activity-mod-queue-504
          Requires 3 more approvals from Devs, Deployers, and QA.
          Martin Santangelo
          Martin Santangelo
          Olivia Madrid
          Olivia Madrid
          Mark Harding
          Mark Harding
          Guy Thouret
          Guy Thouret
          Emiliano Balbuena
          Emiliano Balbuena
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #504

          Deletes source branch

          • Discussion 5
          • Commits 6
          • Pipelines 5
          • Changes 6
          3/4 threads resolved
          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 month ago

            added scoped labels

          • Ben Hayward @benhayward.ben added 69 commits 21 hours ago

            added 69 commits

            • 52f5c842...a8a3fed6 - 68 commits from branch master
            • 009351e2 - Merge branch 'master' of gitlab.com:minds/engine into fix/delete-activity-mod-queue-504

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 21 hours ago

            added 1 commit

            • cbd860b3 - Update

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 9 hours ago
            Resolved by Ben Hayward 5 hours ago
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 9 hours ago
            Resolved by Ben Hayward 5 hours ago
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 9 hours ago
            Resolved by Ben Hayward 4 hours ago
          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 9 hours ago
            Last updated by Ben Hayward 2 hours ago
            Core/Groups/Delegates/PropagateRejection.php
            10 * Propagates activity deletion from the group feed after rejection.
            11 * @package Minds\Core\Groups\Delegates
            12 * @author Ben Hayward
            13 */
            14 class PropagateRejection
            15 {
            16 /**
            17 * Deletes an activity associated with a rejected post.
            18 *
            19 * @param string $guid - activity guid.
            20 * @return boolean - whether deletion was successful
            21 */
            22 public function deleteActivity($guid): bool
            23 {
            24 $activity = new Activity($guid);
            25 return $activity->delete();
            • Mark Harding
              Mark Harding @markeharding · 9 hours ago
              Owner

              Core\Entities\Actions\Delete should be used instead.

            • Ben Hayward @benhayward.ben changed this line in version 4 of the diff 2 hours ago

              changed this line in version 4 of the diff

            • Ben Hayward
              Ben Hayward @benhayward.ben · 2 hours ago
              Developer

              Core\Entities\Actions\Delete was no good here because I'm deleting an activity; that said I created a new Feeds\Action\Delete class, which dispatches to Feeds\Events.

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 9 hours ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added 2 commits 2 hours ago

            added 2 commits

            • 00f211af - Working with new feedback
            • b1f82ae1 - Fixed tests and inconsistant naming pattern

            Compare with previous version

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 2 hours ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added 3 commits 2 hours ago

            added 3 commits

            • b1f82ae1...52a592b9 - 2 commits from branch master
            • 5d25f8fe - Merge branch 'master' of gitlab.com:minds/engine into fix/delete-activity-mod-queue-504

            Compare with previous version

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Awaiting Review Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Martin Santangelo
          user avatar
          Olivia Madrid
          user avatar
          Mark Harding
          user avatar
          Guy Thouret
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          Reference: minds/engine!374