[Sprint/PinkPanther](fix): Delete activity after moderation queue rejection #504
Closes #504
Summary
On production right now, if you reject a post in a group you moderate, the post no longer appears in the queue, but still shows up in the feed for mods only like so:
Testing
- Make a group, make it moderated.
- Login to a secondary account, create posts numbered 1, 2, 3, 4, 5.
- Log-in to primary account, look at the group, see the posts with "awaiting moderation"
- Go to the moderation queue and reject the post numbered 3.
- Check that the activity with the content '3' is not visible on the feed with its "awaiting moderation"
3/4
threads resolved
added scoped labels
added 69 commits
-
52f5c842...a8a3fed6 - 68 commits from branch
master
- 009351e2 - Merge branch 'master' of gitlab.com:minds/engine into fix/delete-activity-mod-queue-504
-
52f5c842...a8a3fed6 - 68 commits from branch
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Resolved by Ben Hayward
- Last updated by Ben Hayward
10 * Propagates activity deletion from the group feed after rejection. 11 * @package Minds\Core\Groups\Delegates 12 * @author Ben Hayward 13 */ 14 class PropagateRejection 15 { 16 /** 17 * Deletes an activity associated with a rejected post. 18 * 19 * @param string $guid - activity guid. 20 * @return boolean - whether deletion was successful 21 */ 22 public function deleteActivity($guid): bool 23 { 24 $activity = new Activity($guid); 25 return $activity->delete(); - Owner
Core\Entities\Actions\Delete
should be used instead. changed this line in version 4 of the diff
- Developer
Core\Entities\Actions\Delete was no good here because I'm deleting an activity; that said I created a new Feeds\Action\Delete class, which dispatches to Feeds\Events.
added scoped label and automatically removed label
added 2 commits
added scoped label and automatically removed label
added 3 commits
-
b1f82ae1...52a592b9 - 2 commits from branch
master
- 5d25f8fe - Merge branch 'master' of gitlab.com:minds/engine into fix/delete-activity-mod-queue-504
-
b1f82ae1...52a592b9 - 2 commits from branch