Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 301
  • Merge Requests 38
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !384

Open
Opened 3 weeks ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/QuietQuail](fix): Blog & media edit updated to new nsfw system #1936

Closes front#1936

Depends on front!613

Testing

Go to a blog, make it nsfw. Upload an image, click it, edit - make that nsfw too.

Check that when you open them they are NSFW. They will likely not be NSFW on feeds due to #1043

This needs repeating for images, video, reminds, in groups etc (have all worked for me)

Edited 2 weeks ago by Ben Hayward
Request to merge fix/blog-media-nsfw-update-1936 into master
Open in Web IDE
Pipeline #97045393 passed for cf9b88dc on fix/blog-media-nsfw-update-1936
          Requires 3 more approvals from Devs, Deployers, and QA.
          Martin Santangelo
          Martin Santangelo
          Olivia Madrid
          Olivia Madrid
          Mark Harding
          Mark Harding
          Guy Thouret
          Guy Thouret
          Emiliano Balbuena
          Emiliano Balbuena
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes front#1936

          Mentions #1043

          Deletes source branch

          • Discussion 4
          • Commits 10
          • Pipelines 8
          • Changes 7
          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 3 weeks ago

            added scoped labels

          • Ben Hayward @benhayward.ben changed the description 3 weeks ago

            changed the description

          • Ben Hayward @benhayward.ben mentioned in merge request front!613 3 weeks ago

            mentioned in merge request front!613

          • Ben Hayward @benhayward.ben added 6 commits 3 weeks ago

            added 6 commits

            • c58d6ffc...4d188166 - 4 commits from branch master
            • 14a2be02 - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
            • 1825a459 - Blog to activity propegation fix.

            Compare with previous version

          • Ben Hayward @benhayward.ben marked as a Work In Progress 3 weeks ago

            marked as a Work In Progress

          • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 3 weeks ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

            added 1 commit

            • 51de081b - Fixed up

            Compare with previous version

          • Ben Hayward @benhayward.ben unmarked as a Work In Progress 2 weeks ago

            unmarked as a Work In Progress

          • Ben Hayward @benhayward.ben changed the description 2 weeks ago

            changed the description

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 2 weeks ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 2 weeks ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

            added 1 commit

            • d58012e8 - Fixed bug with SFW media

            Compare with previous version

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 2 weeks ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added 1 commit 2 weeks ago

            added 1 commit

            • ecb84755 - Lint

            Compare with previous version

          • Mark Harding @markeharding assigned to @xander-miller 2 weeks ago

            assigned to @xander-miller

          • Mark Harding
            Mark Harding @markeharding · 2 weeks ago
            Owner

            @xander-miller please give approval when you are happy with this.

          • Xander Miller @xander-miller approved this merge request 5 days ago

            approved this merge request

          • Xander Miller @xander-miller unapproved this merge request 5 days ago

            unapproved this merge request

          • Xander Miller @xander-miller approved this merge request 5 days ago

            approved this merge request

          • Ben Hayward @benhayward.ben added 1 commit 1 day ago

            added 1 commit

            • 315c1c92 - Update Image.php

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 1 day ago

            added 1 commit

            • 7c02251e - Lint

            Compare with previous version

          • Xander Miller @xander-miller approved this merge request 22 hours ago

            approved this merge request

          • Mark Harding
            Mark Harding @markeharding · 8 hours ago
            Owner

            I am unable to test as I have a 500 error.

            [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "NOTICE: PHP message: Exception #1574156970: Error: Call to a member function getContext() on boolean in /var/www/Minds/front/dist/en/index.php:4"
            [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "Stack trace:"
            [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#0 /var/www/Minds/engine/Core/I18n/I18n.php(123): include()"
            [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#1 /var/www/Minds/engine/Core/Router.php(166): Minds\Core\I18n\I18n->serveIndex()"
            [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#2 /var/www/Minds/engine/index.php(9): Minds\Core\Router->route()"
            [19-Nov-2019 09:49:30] WARNING: [pool www] child 10 said into stderr: "#3 {main}"
            127.0.0.1 -  19/Nov/2019:09:49:30 +0000 "GET /index.php" 500
            
          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 8 hours ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added 61 commits 1 hour ago

            added 61 commits

            • 7c02251e...52a592b9 - 59 commits from branch master
            • 7cedf6a3 - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936
            • cf9b88dc - Merge branch 'master' of gitlab.com:minds/engine into fix/blog-media-nsfw-update-1936

            Compare with previous version

          • Ben Hayward
            Ben Hayward @benhayward.ben · 1 hour ago
            Developer

            Pulled in master, should reset the backend and resolve that.

          • Xander Miller
            Xander Miller @xander-miller · 37 minutes ago
            Developer

            @markeharding test sandbox is back up. You can try reviewing again.

          Please register or sign in to reply
          Assignee
          Xander Miller's avatar
          Xander Miller @xander-miller
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Martin Santangelo
          user avatar
          Olivia Madrid
          user avatar
          Mark Harding
          user avatar
          Guy Thouret
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Brian Hatchet
          Reference: minds/engine!384