Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 813
  • Merge Requests 51
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !649

Closed
Opened 1 week ago by Ben Hayward@benhayward.ben
Report abuse

Adjusted dropdown menus to have a larger clickable area #2223

Let me know what you think of this approach @markeharding.

It was majorly awkward because there are multiple places that these classes are used.

image image image image image image image

Testing

Find dropdowns and check they're not broken - note some dropdowns like the discovery are horizontal.

Edited 14 hours ago by Ben Hayward
Request to merge fix/dropdown-item-padding-2223 into master
Pipeline #96784628 passed with warnings for b046e257 on fix/dropdown-item-padding-2223
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Mark Harding
              Mark Harding
              Xander Miller
              Xander Miller

              Closed by Mark Harding 17 minutes ago

              The changes were not merged into master

              Mentions #2223

              Deletes source branch

              • Discussion 6
              • Commits 4
              • Pipelines 4
              • Changes 9
              1/1 thread resolved
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 week ago

                added scoped labels

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                Resolved by Ben Hayward 14 hours ago
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 week ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 1 commit 14 hours ago

                added 1 commit

                • d10fb49e - Fix dropdown menu click area #2223

                Compare with previous version

              • Ben Hayward @benhayward.ben added 1 commit 14 hours ago

                added 1 commit

                • 187e8368 - Comments left in

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 14 hours ago

                changed the description

              • Ben Hayward @benhayward.ben resolved all threads 14 hours ago

                resolved all threads

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 14 hours ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 29 commits 14 hours ago

                added 29 commits

                • 187e8368...a0d1737e - 28 commits from branch master
                • b046e257 - Merge branch 'master' of gitlab.com:minds/front into fix/dropdown-item-padding-2223

                Compare with previous version

              • Mark Harding
                Mark Harding @markeharding · 17 minutes ago
                Owner

                The tradeoff of introducing so many regressions for such a trivial issue is simply not worth it. Screenshot_2019-11-19_at_09.20.57. Instead we will just work on the new dropdown area following new designs.

                Simply introducing a new class on our topbar dropdown area could have made this simple.

              • Mark Harding @markeharding closed 17 minutes ago

                closed

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Olivia Madrid
              user avatar
              Emiliano Balbuena
              user avatar
              Brian Hatchet
              user avatar
              Juan Manuel Solaro
              user avatar
              Mark Harding
              user avatar
              Guy Thouret
              user avatar
              Martin Santangelo
              Reference: minds/front!649