[Sprint/RollingRabbit](fix): Updated returned exception of offending spam link. #1104
Replication
Try to post a blog with bit.ly Try to post to newsfeed.
added scoped labels
- Owner
added scoped label and automatically removed label
added 1 commit
- 4251ac5a - Combined prohibited list into single source.
added scoped label and automatically removed label
- Resolved by Ben Hayward
added scoped label and automatically removed label
added 15 commits
-
6ebcc9a4...01c4ac21 - 13 commits from branch
master
- 7d83a458 - Removing file
- 66b6430f - Merge branch 'master' of gitlab.com:minds/engine into fix/spam-detection-return-1104
-
6ebcc9a4...01c4ac21 - 13 commits from branch
added scoped label and automatically removed label
resolved all threads
- Developer
Checking this out locally, the linter is passing
- Owner
make sure you are upgraded to php 7.3 locally with the latest linter too
- Resolved by Ben Hayward
- Last updated by Ben Hayward
342 49 return true; 343 50 } 344 51 52 /** 53 * Returns true if the object bodies contain a prohibited domain. 54 * 55 * @param $object - excepts fields description, briefdescription, message and title. 56 * @return boolean - true if prohibited domain found. 57 */ 58 public function containsProhibitedDomain($object) 59 { 60 $prohibitedDomains = $this->config->get('prohibited_domains'); - Owner
I don't think this should be inside of settings.php. A very large array is now going to be instantiated every request which is a poor use of memory. Also we need to be transparent about what domains are prohibited.
- Developer
Good point
changed this line in version 10 of the diff
added scoped label and automatically removed label
added 2 commits
added 15 commits
-
4f014594...a8a3fed6 - 13 commits from branch
master
- 80cc44b3 - Lint
- 61c5f6aa - Merge branch 'master' of gitlab.com:minds/engine into fix/spam-detection-return-1104
-
4f014594...a8a3fed6 - 13 commits from branch