Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 806
  • Merge Requests 54
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !660

Open
Opened 2 days ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/RollingRabbit](fix): Swapped out old failing datepicker library

Closes #2171

Summary

The old date-picker component was broken (the one that is used on the wallet pages as filters). Swapping out other components to use this format is out of the scope of this MR, but would be worth consideration.

https://github.com/DanielYKPan/date-time-picker - Actively maintained, quite a lot of functionality that's easy to reach (e.g. min and max).

image

Testing

  • Test the date components of the site, make sure they all work as intended.
  • Make sure filters values are respected in relation to the returned transactions.
Request to merge fix/date-picker-transactions-2171 into master
The source branch is 7 commits behind the target branch
Open in Web IDE
Pipeline #96708770 failed for 5f793ea8 on fix/date-picker-transactions-2171
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2171

              Deletes source branch

              • Discussion 2
              • Commits 2
              • Pipelines 2
              • Changes 8
              1/1 thread resolved
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 2 days ago

                added scoped labels

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 4 hours ago
                Resolved by Ben Hayward 33 minutes ago
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 4 hours ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 1 commit 33 minutes ago

                added 1 commit

                • 5f793ea8 - Removed old package

                Compare with previous version

              • Ben Hayward @benhayward.ben resolved all threads 33 minutes ago

                resolved all threads

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Olivia Madrid
              user avatar
              Mark Harding
              user avatar
              Emiliano Balbuena
              user avatar
              Juan Manuel Solaro
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              user avatar
              Brian Hatchet
              Reference: minds/front!660