Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 299
  • Merge Requests 39
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !388

Merged
Opened 1 week ago by Marcelo Rivera@eiennohi
Report abuse

Remove asset signing for public posts

closes #914 (closed) closes #1092 (closed)

Edited 1 week ago by Marcelo Rivera
Request to merge fix/remove-public-asset-signing into master
Pipeline #96624104 passed for c8041743 on fix/remove-public-asset-signing
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Olivia Madrid
          Olivia Madrid
          Emiliano Balbuena
          Emiliano Balbuena
          Ben Hayward
          Ben Hayward
          Rami Albatal
          Rami Albatal
          Guy Thouret
          Guy Thouret

          Merged by Mark Harding 43 minutes ago

          The changes were merged into master with f2cde2bf

          The source branch has been deleted

          Closed #1092 (closed) and #914 (closed)

          Pipeline #96624768 waiting for manual action for f2cde2bf on master
                        • Discussion 9
                        • Commits 6
                        • Pipelines 6
                        • Changes 7
                        6/7 threads resolved
                        • Marcelo Rivera @eiennohi added Squad::Yellow scoped label 1 week ago

                          added scoped label

                        • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                          added 1 commit

                          • 2a395c1d - (fix): spec tests

                          Compare with previous version

                        • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                          added 1 commit

                          • cba0d53b - (fix): spec tests

                          Compare with previous version

                        • Marcelo Rivera
                          Marcelo Rivera @eiennohi · 1 week ago
                          Developer

                          tested with both public newsfeed and closed group activities

                        • Marcelo Rivera @eiennohi added 1 commit 1 week ago

                          added 1 commit

                          • 3c748de9 - (fix): spec tests

                          Compare with previous version

                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                          Resolved by Marcelo Rivera 1 week ago
                        • Mark Harding
                          Mark Harding @markeharding started a thread on the diff 1 week ago
                          Resolved by Marcelo Rivera 1 week ago
                        • Mark Harding
                          Mark Harding @markeharding started a thread on the diff 1 week ago
                          Resolved by Marcelo Rivera 1 week ago
                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                          Resolved by Marcelo Rivera 1 week ago
                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                          Resolved by Marcelo Rivera 1 week ago
                        • Mark Harding @markeharding added MR::Requires Changes scoped label 1 week ago

                          added scoped label

                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                          Resolved by Marcelo Rivera 1 week ago
                        • Marcelo Rivera @eiennohi added 2 commits 1 week ago

                          added 2 commits

                          • 11626dbb - (fix): use Common\Access::PUBLIC
                          • db383222 - (fix): use injected EntitiesBuilder

                          Compare with previous version

                        • Marcelo Rivera @eiennohi resolved all threads 1 week ago

                          resolved all threads

                        • Marcelo Rivera @eiennohi mentioned in issue #1092 (closed) 1 week ago

                          mentioned in issue #1092 (closed)

                        • Marcelo Rivera @eiennohi changed the description 1 week ago

                          changed the description

                        • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 week ago

                          added scoped label and automatically removed label

                        • Mark Harding
                          Mark Harding @markeharding started a thread on the diff 51 minutes ago
                          Controllers/api/v1/media/thumbnails.php
                          32 $guid = $pages[0];
                          33 33
                          34 if ($featuresManager->has('cdn-jwt')) {
                          35 error_log("{$_SERVER['REQUEST_URI']} was hit, and should not have been");
                          34 Core\Security\ACL::$ignore = true;
                          35
                          36 $size = isset($pages[1]) ? $pages[1] : null;
                          37
                          38 $last_cache = isset($pages[2]) ? $pages[2] : time();
                          39
                          40 $entity = Entities\Factory::build($guid);
                          36 41
                          42 if (!$entity) {
                          37 43 return Factory::response([
                          38 44 'status' => 'error',
                          39 'message' => 'This endpoint has been deprecated. Please use fs/v1/thumbnail',
                          • Mark Harding
                            Mark Harding @markeharding · 51 minutes ago
                            Owner

                            This endpoint should be deprecated?

                          • Please register or sign in to reply
                        • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 51 minutes ago

                          added scoped label and automatically removed label

                        • Mark Harding @markeharding added 33 commits 45 minutes ago

                          added 33 commits

                          • db383222...7a379e7d - 32 commits from branch master
                          • c8041743 - Merge branch 'master' of gitlab.com:minds/engine into fix/remove-public-asset-signing

                          Compare with previous version

                        • Mark Harding @markeharding approved this merge request 43 minutes ago

                          approved this merge request

                        • Mark Harding @markeharding mentioned in commit f2cde2bf 43 minutes ago

                          mentioned in commit f2cde2bf

                        • Mark Harding @markeharding merged 43 minutes ago

                          merged

                        Please register or sign in to reply
                        0 Assignees
                        None
                        None
                        Milestone
                        None
                        Time tracking
                        No estimate or time spent
                        2
                        Labels
                        MR::Requires Changes Squad::Yellow
                        Lock merge request
                        Unlocked
                        10
                        10 participants
                        user avatar
                        Olivia Madrid
                        user avatar
                        Emiliano Balbuena
                        user avatar
                        Ben Hayward
                        user avatar
                        Rami Albatal
                        user avatar
                        Guy Thouret
                        user avatar
                        Martin Santangelo
                        user avatar
                        Brian Hatchet
                        Reference: minds/engine!388