Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 299
  • Merge Requests 39
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !396

Open
Opened 5 days ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/RollingRabbit](fix): Wallet balance caching #1115

Closes #1115

Testing

Deploy on domain connected to live data if possible. Need to ensure the balance is still loaded across the site.

Edited 5 days ago by Ben Hayward
Request to merge fix/wallet-balance-caching-1115 into master
The source branch is 13 commits behind the target branch
Open in Web IDE
Pipeline #95431619 passed for d169ef05 on fix/wallet-balance-caching-1115
          Requires 3 more approvals from Devs, Deployers, and QA.
          Olivia Madrid
          Olivia Madrid
          Mark Harding
          Mark Harding
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera
          Rami Albatal
          Rami Albatal
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes #1115

          Deletes source branch

          • Discussion 2
          • Commits 2
          • Pipelines 2
          • Changes 3
          0/1 thread resolved
          • Ben Hayward @benhayward.ben changed the description 5 days ago

            changed the description

          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 5 days ago

            added scoped labels

          • Ben Hayward
            Ben Hayward @benhayward.ben · 5 days ago
            Developer

            I expect some front-end changes will need to go along with this. Just want to verify this is the correct approach first.

            Edited by Ben Hayward 5 days ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 17 minutes ago
            Core/Blockchain/Wallets/OnChain/Balance.php
            60 60 }
            61 61
            62 62 $balance = $this->token->balanceOf($address);
            63
            64 if ($balance === null) {
            65 throw new \Exception('Unable to retrieve balance');
            • Mark Harding
              Mark Harding @markeharding · 17 minutes ago
              Owner

              Why are we using exceptions here vs simply throwing null?

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 17 minutes ago

            added scoped label and automatically removed label

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Olivia Madrid
          user avatar
          Mark Harding
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Rami Albatal
          user avatar
          Guy Thouret
          user avatar
          Martin Santangelo
          Reference: minds/engine!396