Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 299
  • Merge Requests 39
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !391

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/RollingRabbit](fix): Updated returned exception of offending spam link. #1104

Replication

Try to post a blog with bit.ly Try to post to newsfeed.

Request to merge fix/spam-detection-return-1104 into master
The source branch is 13 commits behind the target branch
Open in Web IDE
Pipeline #95371963 failed for 66b6430f on fix/spam-detection-return-1104
          Requires 3 more approvals from Devs, Deployers, and QA.
          Olivia Madrid
          Olivia Madrid
          Guy Thouret
          Guy Thouret
          Mark Harding
          Mark Harding
          Emiliano Balbuena
          Emiliano Balbuena
          Marcelo Rivera
          Marcelo Rivera
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Mentions #1104

          Deletes source branch

          • Discussion 6
          • Commits 9
          • Pipelines 10
          • Changes 6
          1/4 threads resolved
          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 week ago

            added scoped labels

          • Mark Harding
            Mark Harding @markeharding · 1 week ago
            Owner

            Screen_Shot_2019-11-07_at_2.09.55_PM

            Looks like the newsfeed isn't included in this change?

          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 week ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added 1 commit 1 week ago

            added 1 commit

            • 4251ac5a - Combined prohibited list into single source.

            Compare with previous version

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 week ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added 1 commit 1 week ago

            added 1 commit

            • 4a0642ef - Adding tests

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 1 week ago

            added 1 commit

            • ba436a4f - Quick formatting change

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 1 week ago

            added 1 commit

            • 8106b05a - Lint

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding started a thread on an old version of the diff 6 days ago
            Resolved by Ben Hayward 5 days ago
          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 6 days ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben added 1 commit 5 days ago

            added 1 commit

            • 5aedb8ee - Accidentally commited file

            Compare with previous version

          • Ben Hayward @benhayward.ben added 1 commit 5 days ago

            added 1 commit

            • 6ebcc9a4 - Reverting accidental file commit

            Compare with previous version

          • Ben Hayward @benhayward.ben added 15 commits 5 days ago

            added 15 commits

            • 6ebcc9a4...01c4ac21 - 13 commits from branch master
            • 7d83a458 - Removing file
            • 66b6430f - Merge branch 'master' of gitlab.com:minds/engine into fix/spam-detection-return-1104

            Compare with previous version

          • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 5 days ago

            added scoped label and automatically removed label

          • Ben Hayward @benhayward.ben resolved all threads 5 days ago

            resolved all threads

            • Ben Hayward
              Ben Hayward @benhayward.ben · 5 days ago
              Developer

              Checking this out locally, the linter is passing

            • Collapse replies
            • Mark Harding
              Mark Harding @markeharding · 5 days ago
              Owner

              make sure you are upgraded to php 7.3 locally with the latest linter too

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 12 minutes ago
            Core/Security/Events.php
            342 49 return true;
            343 50 }
            344 51
            52 /**
            53 * Returns true if the object bodies contain a prohibited domain.
            54 *
            55 * @param $object - excepts fields description, briefdescription, message and title.
            56 * @return boolean - true if prohibited domain found.
            57 */
            58 public function containsProhibitedDomain($object)
            • Mark Harding
              Mark Harding @markeharding · 12 minutes ago
              Owner

              need return type

            • Please register or sign in to reply
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 12 minutes ago
            Core/Security/Events.php
            342 49 return true;
            343 50 }
            344 51
            52 /**
            53 * Returns true if the object bodies contain a prohibited domain.
            54 *
            55 * @param $object - excepts fields description, briefdescription, message and title.
            56 * @return boolean - true if prohibited domain found.
            57 */
            58 public function containsProhibitedDomain($object)
            59 {
            60 $prohibitedDomains = $this->config->get('prohibited_domains');
            • Mark Harding
              Mark Harding @markeharding · 12 minutes ago
              Owner

              I don't think this should be inside of settings.php. A very large array is now going to be instantiated every request which is a poor use of memory. Also we need to be transparent about what domains are prohibited.

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 12 minutes ago

            added scoped label and automatically removed label

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Olivia Madrid
          user avatar
          Guy Thouret
          user avatar
          Mark Harding
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          Reference: minds/engine!391