Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 806
  • Merge Requests 54
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !643

Merged
Opened 1 week ago by Emiliano Balbuena@edgebal
Report abuse

(refactor): Remove engine logic from front/index.php

Testing

  • Open sandbox URL.
  • Ensure it works completely.

Might be best to test on staging or on a subdomain.

Issues

  • Closes #2216 (closed)
Request to merge refactor/decouple-front-index into master
Pipeline #96299272 passed with warnings for 7687998d on refactor/decouple-front-index
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              All merge request dependencies have been merged (1 merged)

              Merged by Mark Harding 10 minutes ago

              The changes were merged into master with a0d1737e

              The source branch has been deleted

              Closed #2216 (closed)

              Pipeline #96627859 running for a0d1737e on master
                            • Discussion 2
                            • Commits 3
                            • Pipelines 3
                            • Changes 1
                            1/1 thread resolved
                            • Emiliano Balbuena @edgebal added Product::Platform Squad::Yellow scoped labels 1 week ago

                              added scoped labels

                            • Emiliano Balbuena @edgebal mentioned in merge request engine!390 (merged) 1 week ago

                              mentioned in merge request engine!390 (merged)

                            • Emiliano Balbuena @edgebal mentioned in issue #2216 (closed) 1 week ago

                              mentioned in issue #2216 (closed)

                            • Mark Harding
                              Mark Harding @markeharding started a thread on an old version of the diff 6 days ago
                              Resolved by Emiliano Balbuena 2 days ago
                            • Mark Harding @markeharding added MR::Requires Changes scoped label 6 days ago

                              added scoped label

                            • Emiliano Balbuena @edgebal added 40 commits 2 days ago

                              added 40 commits

                              • c099ae3e...cb6d9921 - 39 commits from branch master
                              • 6ea45391 - Merge remote-tracking branch 'origin/master' into refactor/decouple-front-index

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 2 days ago

                              added 1 commit

                              • 7687998d - (chore): Not supported detection on head

                              Compare with previous version

                            • Emiliano Balbuena @edgebal resolved all threads 2 days ago

                              resolved all threads

                            • Emiliano Balbuena @edgebal added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 2 days ago

                              added scoped label and automatically removed label

                            • Mark Harding @markeharding approved this merge request 10 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding mentioned in commit a0d1737e 10 minutes ago

                              mentioned in commit a0d1737e

                            • Mark Harding @markeharding merged 10 minutes ago

                              merged

                            Please register or sign in to reply
                            Assignee
                            Emiliano Balbuena's avatar
                            Emiliano Balbuena @edgebal
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            3
                            Labels
                            MR::Awaiting Review Product::Platform Squad::Yellow
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Olivia Madrid
                            user avatar
                            Guy Thouret
                            user avatar
                            Ben Hayward
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Martin Santangelo
                            user avatar
                            Brian Hatchet
                            user avatar
                            Juan Manuel Solaro
                            Reference: minds/front!643