[Sprint/RollingRabbit](fix): Blocked channels eternally loading. #2244
Closes #2244
Summary
Currently, users on production who have nobody blocked will see an ever-spinning loading icon.
Testing
- Check /settings/blocked-channels
- Observe that when channels are blocked, they are shown, when channels are not blocked, the loading icon does not endlessly display.
Reasoning
I'm throwing an error to end the observable lifecycle. The filter with this approach is redundant.
Request to merge
fix/blocked-channels-bug-2244
into
master
The source branch is 8 commits behind the target branch
0/1
thread resolved
added scoped labels
35 36 ngOnInit() { 36 37 this.load(true); 37 38 this.channels = this.blockListService.blocked.pipe( 38 tap(() => { 39 tap(list => { 39 40 this.inProgress = true; 40 41 this.moreData = false; // Support pagination in the future 42 43 if (list.length < 1) { 44 throw new Error('No more entities'); ![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
Owner"Channels" not entities.
added scoped label and automatically removed label
