We have been getting OOM messages from finfo calls that get the mime type from a file buffer. See #1120 for full details.

This MR touches a number of different API endpoints for fetching and also changes the S3 Service write method so affects any media file upload.

/api/fs/v1/avatars

/api/fs/v1/banners

/api/fs/v1/paywall

/api/fs/v1/thumbnail <- This was producing the most errors given the number of times it gets hit

Some steps for reproduction:

1. Try to post a media file that exceeds 13M in size to the nesfeed.
2. POST /api/v1/media request will return a 200 OK status with Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 146703512 bytes) in /var/www/Minds/engine/Core/Storage/Services/S3.php on line 67 as the response

When this gets to staging, accessing the following URL should be successful, currently fails in production: https://www.minds.com/fs/v1/thumbnail/1026508015016828928/xlarge

added scoped labels

added 1 commit

• f8fddc82 - (chore) Lint new File class - #1120

Compare with previous version

marked as a Work In Progress

changed the description

added 1 commit

• af223984 - (chore) Move File from Core to Helpers namespace - #1120

Compare with previous version

added 2 commits

• 1c80f2d0 - (fix) Unset handle (S3Client object) when serialize is called on ElggFile as...
• d99e67aa - (fix) Trim leading slash from filename in Media\Assets\Image::upload method - #1120

Compare with previous version

unmarked as a Work In Progress

changed title from to

mentioned in issue minds#920 (closed)

approved this merge request

merged

mentioned in commit 7a379e7d