Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 807
  • Merge Requests 55
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !638

Open
Opened 1 week ago by Olivia Madrid@omadrid
Report abuse

Refactor PRO settings

How to test

From a non-admin

  1. Go to https://eggman.minds.com
  2. Login with a channel that has Minds Pro enable
  3. Navigate to the pro settings via the channel page or the settings console
  4. Change settings, avatars, backgrounds and confirm they save

From an admin

  1. Repeat the steps above from an admin account, but go to someone elses channel instead.
Edited 2 days ago by Mark Harding
Request to merge pro-settings-2163 into master
The source branch is 2 commits behind the target branch
Open in Web IDE
Pipeline #96340114 failed for 16f1375c on pro-settings-2163
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request
              • Discussion 4
              • Commits 43
              • Pipelines 13
              • Changes 48
              • Olivia Madrid @omadrid changed milestone to %Pro Beta #release 1 week ago

                changed milestone to %Pro Beta #release

              • Olivia Madrid @omadrid added Platform::Browser Priority::1 - High Product::Pro Squad::Blue Type::Refactor scoped labels 1 week ago

                added scoped labels

              • Olivia Madrid @omadrid added 1 commit 1 week ago

                added 1 commit

                • 767c36c4 - (refactor): PRO settings form styles

                Compare with previous version

              • Olivia Madrid @omadrid added 42 commits 5 days ago

                added 42 commits

                • 767c36c4...422d7d5f - 40 commits from branch master
                • dfff4916 - (refactor): form toaster
                • d47cd260 - Merge branch 'master' of gitlab.com:minds/front into pro-settings-2163

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 4 days ago

                added 1 commit

                • 1e5ca232 - (fix): linting issues post merge

                Compare with previous version

              • Olivia Madrid @omadrid added 3 commits 3 days ago

                added 3 commits

                • 78b06555 - (refactor): split tabs into individual forms
                • a3c569e9 - (refactor): more pro settings validation and ui
                • a135d23e - Merge branch 'pro-settings-2163' of gitlab.com:minds/front into pro-settings-2163

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 3 days ago

                added 1 commit

                • 52cd1f90 - (feat): use form groups

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 3 days ago

                added 1 commit

                • ba68b78d - (chore): minor fixes to pro settings

                Compare with previous version

              • Olivia Madrid @omadrid added 3 commits 2 days ago

                added 3 commits

                • caaa844c - (chore): update hex validator pattern
                • a8f48939 - Merge branch 'pro-settings-2163' of gitlab.com:minds/front into pro-settings-2163
                • d50b0fb5 - (refactor): communication btwn draggableList and FormArray

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 2 days ago

                added 1 commit

                • 5ac0055e - (fix): various fixes for pro settings

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 2 days ago

                added 1 commit

                • 36499dfe - (fix): failing tests

                Compare with previous version

              • Mark Harding @markeharding unmarked as a Work In Progress 2 days ago

                unmarked as a Work In Progress

              • Mark Harding @markeharding assigned to @xander-miller, @jotto141, and @ottman 2 days ago

                assigned to @xander-miller, @jotto141, and @ottman

              • Mark Harding @markeharding added MR::Ready to Merge scoped label 2 days ago

                added scoped label

              • Mark Harding @markeharding changed the description 2 times within 1 minute 2 days ago

                changed the description 2 times within 1 minute

              • Mark Harding @markeharding added 6 commits 2 days ago

                added 6 commits

                • 36499dfe...cb6d9921 - 4 commits from branch master
                • 76c5db04 - Merge branch 'master' of gitlab.com:minds/front into pro-settings-2163
                • eba84d39 - (feat): implement payout methods for pro

                Compare with previous version

              • Mark Harding @markeharding added 1 commit 2 days ago

                added 1 commit

                • 57c998dd - (fix): logo showing cached version post upload

                Compare with previous version

              • Xander Miller @xander-miller approved this merge request 1 day ago

                approved this merge request

              • Xander Miller
                Xander Miller @xander-miller · 1 day ago
                Developer

                I found some minor issues that I reported but functionality is sound.

              • Olivia Madrid @omadrid added 1 commit 1 day ago

                added 1 commit

                • 16f1375c - (refactor): sidebar menu is now only populated with a menu object as input

                Compare with previous version

              • Bill Ottman
                Bill Ottman :dragon_face: @ottman · 1 day ago
                Owner

                Time aspect ratio buttons on mobile web a bit off.

                Screenshot_20191114-204759_Brave

                Edited by Bill Ottman 22 hours ago
              • Bill Ottman
                Bill Ottman :dragon_face: @ottman · 22 hours ago
                Owner

                After changing logo and banner, it saved, but reverted to my old logo and avatar. Then I refreshed and the new ones appeared, having uploaded succesfully. https://bill.minds.com

                protest1

              • Bill Ottman
                Bill Ottman :dragon_face: @ottman · 22 hours ago
                Owner

                @markeharding I commented some issues(not sure why no one else found what I found as it is the most basic failure for this test), but unsure if that's how you'd prefer this to be done. Not sure about what to in the future when there are no more issues.

                Also, a little bit confused about the blue and greens. I think we need to pick one

              Please register or sign in to reply
              3 Assignees
              Bill Ottman's avatar
              Jack Ottman's avatar
              Xander Miller's avatar
              Pro Beta #release
              Milestone
              Pro Beta #release
              Time tracking
              No estimate or time spent
              6
              Labels
              MR::Ready to Merge Platform::Browser Priority::1 - High Product::Pro Squad::Blue Type::Refactor
              Lock merge request
              Unlocked
              12
              12 participants
              user avatar
              Mark Harding
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              user avatar
              Ben Hayward
              user avatar
              Juan Manuel Solaro
              user avatar
              Emiliano Balbuena
              user avatar
              Martin Santangelo
              Reference: minds/front!638