Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 806
  • Merge Requests 53
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !657

Open
Opened 1 hour ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/RollingRabbit](fix): Blocked channels eternally loading. #2244

Closes #2244

Summary

Currently, users on production who have nobody blocked will see an ever-spinning loading icon.

Testing

  • Check /settings/blocked-channels
  • Observe that when channels are blocked, they are shown, when channels are not blocked, the loading icon does not endlessly display.

Reasoning

I'm throwing an error to end the observable lifecycle. The filter with this approach is redundant.

Request to merge fix/blocked-channels-bug-2244 into master
Open in Web IDE
Pipeline #95999897 passed with warnings for 12a67e6f on fix/blocked-channels-bug-2244
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Mark Harding
              Mark Harding
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2244

              Deletes source branch

              • Discussion 0
              • Commits 1
              • Pipelines 1
              • Changes 1
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 hour ago

                added scoped labels

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Awaiting Review Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Emiliano Balbuena
              user avatar
              Martin Santangelo
              user avatar
              Juan Manuel Solaro
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              user avatar
              Brian Hatchet
              Reference: minds/front!657