Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 297
  • Merge Requests 42
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !397

Open
Opened 4 hours ago by Guy Thouret@gthouret
Report abuse

WIP: Memory efficient method of getting Mime Types

We have been getting OOM messages from finfo calls that get the mime type from a file buffer. See #1120 for full details.

This MR touches a number of different API endpoints for fetching and also changes the S3 Service write method so affects any media file upload.

/api/fs/v1/avatars

/api/fs/v1/banners

/api/fs/v1/paywall

/api/fs/v1/thumbnail <- This was producing the most errors given the number of times it gets hit

Some steps for reproduction:

  1. Try to post a media file that exceeds 13M in size to the nesfeed.
  2. POST /api/v1/media request will return a 200 OK status with Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 146703512 bytes) in /var/www/Minds/engine/Core/Storage/Services/S3.php on line 67 as the response

When this gets to staging, accessing the following URL should be successful, currently fails in production: https://www.minds.com/fs/v1/thumbnail/1026508015016828928/xlarge

Edited 3 hours ago by Guy Thouret
Request to merge fix/1120-thumbnail-oom into master
Open in Web IDE
Pipeline #95622422 passed for af223984 on fix/1120-thumbnail-oom
          Requires 3 more approvals from Devs, Deployers, and QA.
          Olivia Madrid
          Olivia Madrid
          Martin Santangelo
          Martin Santangelo
          Rami Albatal
          Rami Albatal
          Marcelo Rivera
          Marcelo Rivera
          Emiliano Balbuena
          Emiliano Balbuena
          This is a Work in Progress

          Mentions #1120

          You can merge this merge request manually using the
          • Discussion 0
          • Commits 5
          • Pipelines 3
          • Changes 8
          • Guy Thouret @gthouret added MR::Awaiting Review Priority::1 - High Regression::Production Squad::Blue scoped labels 4 hours ago

            added scoped labels

          • Guy Thouret @gthouret added 1 commit 4 hours ago

            added 1 commit

            • f8fddc82 - (chore) Lint new File class - #1120

            Compare with previous version

          • Guy Thouret @gthouret marked as a Work In Progress 3 hours ago

            marked as a Work In Progress

          • Guy Thouret @gthouret changed the description 3 hours ago

            changed the description

          • Guy Thouret @gthouret added 1 commit 3 hours ago

            added 1 commit

            • af223984 - (chore) Move File from Core to Helpers namespace - #1120

            Compare with previous version

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          4
          Labels
          MR::Awaiting Review Priority::1 - High Regression::Production Squad::Blue
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Olivia Madrid
          user avatar
          Martin Santangelo
          user avatar
          Rami Albatal
          user avatar
          Marcelo Rivera
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Brian Hatchet
          Reference: minds/engine!397