Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 799
  • Merge Requests 48
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !651

Merged
Opened 1 day ago by Emiliano Balbuena@edgebal
Report abuse

(fix): Mass NSFW XHR trigger when admins view posts

Testing

  • Log in as an admin
  • Open Dev Tools > Network
  • Reload the page (IMPORTANT STEP)
  • Visit a channel that has posts (the more, the better)
  • Ensure there are NO XHR requests to /v2/admin/nsfw/<numeric_value>

Issues

  • Closes #2231.
Edited 1 day ago by Emiliano Balbuena
Request to merge hotfix/mass-nsfw-xhr-bug into master
Pipeline #95374978 failed for 1b1be1f4 on hotfix/mass-nsfw-xhr-bug
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller

              Merged by Mark Harding 54 minutes ago

              The changes were merged into master with 422d7d5f

              The source branch has been deleted

              Pipeline #95376004 waiting for manual action for 422d7d5f on master
                            • Discussion 1
                            • Commits 5
                            • Pipelines 4
                            • Changes 7
                            0/1 thread resolved
                            • Emiliano Balbuena @edgebal added Product::Platform Squad::Yellow scoped labels 1 day ago

                              added scoped labels

                            • Emiliano Balbuena @edgebal changed the description 1 day ago

                              changed the description

                            • Emiliano Balbuena @edgebal added 4 commits 1 day ago

                              added 4 commits

                              • 835d6913...e5e50c2b - 2 commits from branch master
                              • a6727572 - Merge remote-tracking branch 'origin/master' into hotfix/mass-nsfw-xhr-bug
                              • cb2efedd - (cs): Lint

                              Compare with previous version

                            • Emiliano Balbuena @edgebal added 1 commit 1 day ago

                              added 1 commit

                              • 9de57d28 - (cs): Lint (ii)

                              Compare with previous version

                            • Mark Harding
                              Mark Harding @markeharding started a thread on an old version of the diff 6 hours ago
                              Last updated by Emiliano Balbuena 57 minutes ago
                              src/app/common/components/post-menu/post-menu.component.ts
                              345 345 }
                              346 346
                              347 347 onNSFWSelected(reasons: Array<{ label; value; selected }>) {
                              348 console.log('yo');
                              • Mark Harding
                                Mark Harding @markeharding · 6 hours ago
                                Owner

                                :eyes:

                              • Emiliano Balbuena @edgebal changed this line in version 4 of the diff 57 minutes ago

                                changed this line in version 4 of the diff

                              • Please register or sign in to reply
                            • Mark Harding @markeharding added MR::Requires Changes scoped label 6 hours ago

                              added scoped label

                            • Emiliano Balbuena @edgebal added 1 commit 57 minutes ago

                              added 1 commit

                              • 1b1be1f4 - (fix): Unwanted console.log

                              Compare with previous version

                            • Mark Harding @markeharding approved this merge request 54 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding mentioned in commit 422d7d5f 54 minutes ago

                              mentioned in commit 422d7d5f

                            • Mark Harding @markeharding merged 54 minutes ago

                              merged

                            Please register or sign in to reply
                            Assignee
                            Emiliano Balbuena's avatar
                            Emiliano Balbuena @edgebal
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            3
                            Labels
                            MR::Requires Changes Product::Platform Squad::Yellow
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Ben Hayward
                            user avatar
                            Guy Thouret
                            user avatar
                            Martin Santangelo
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Olivia Madrid
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Brian Hatchet
                            Reference: minds/front!651