Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 298
  • Merge Requests 39
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !380

Merged
Opened 3 weeks ago by Marcelo Rivera@eiennohi
Report abuse

Implement new delete for channel delete to record delete event in elasticsearch

closes https://gitlab.com/minds/analytics/issues/32 closes #1093 (closed)

Edited 6 days ago by Marcelo Rivera
Request to merge feat/new-delete-event-32 into master
Pipeline #95339001 passed for ff585166 on feat/new-delete-event-32
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Rami Albatal
          Rami Albatal
          Ben Hayward
          Ben Hayward
          Guy Thouret
          Guy Thouret
          Emiliano Balbuena
          Emiliano Balbuena
          Martin Santangelo
          Martin Santangelo

          Merged by Mark Harding 2 minutes ago

          The changes were merged into master with 01c4ac21

          The source branch has been deleted

          Closed #1093 (closed)

          Pipeline #95365531 running for 01c4ac21 on master
                        • Discussion 5
                        • Commits 4
                        • Pipelines 5
                        • Changes 3
                        1/1 thread resolved
                        • Marcelo Rivera @eiennohi changed milestone to %Misc. Q4 2019 3 weeks ago

                          changed milestone to %Misc. Q4 2019

                        • Marcelo Rivera @eiennohi added Squad::Yellow scoped label 3 weeks ago

                          added scoped label

                        • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                          added 1 commit

                          • 53e1f9cb - (fix): remove 'phpspec' as pagingStateToken in tests

                          Compare with previous version

                        • Marcelo Rivera @eiennohi added 1 commit 3 weeks ago

                          added 1 commit

                          • 80522e2f - (feat): add new MetricsDelegate that pushes the new delete analytics event

                          Compare with previous version

                        • Mark Harding
                          Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                          Resolved by Marcelo Rivera 6 days ago
                        • Mark Harding @markeharding added MR::Requires Changes scoped label 1 week ago

                          added scoped label

                        • Marcelo Rivera @eiennohi added 32 commits 6 days ago

                          added 32 commits

                          • 80522e2f...af77626a - 30 commits from branch master
                          • 9049aaef - Merge remote-tracking branch 'upstream/master' into feat/new-delete-event-32
                          • 71b075b3 - (fix): metricsDelegate->onDelete() should be called outside of foreach

                          Compare with previous version

                        • Marcelo Rivera @eiennohi mentioned in issue #1093 (closed) 6 days ago

                          mentioned in issue #1093 (closed)

                        • Marcelo Rivera @eiennohi changed the description 6 days ago

                          changed the description

                        • Marcelo Rivera @eiennohi resolved all threads 6 days ago

                          resolved all threads

                        • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 6 days ago

                          added scoped label and automatically removed label

                        • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 4 days ago

                          added scoped label and automatically removed label

                        • Mark Harding
                          Mark Harding @markeharding · 4 days ago
                          Owner

                          Linter now failing. You can get gitlab to send you emails for CI failures fyi.

                        • Mark Harding
                          Mark Harding @markeharding · 4 hours ago
                          Owner

                          @eiennohi please make sure you are keeping on top of these.

                        • Marcelo Rivera @eiennohi added 1 commit 1 hour ago

                          added 1 commit

                          • ff585166 - (fix): lint

                          Compare with previous version

                        • Marcelo Rivera
                          Marcelo Rivera @eiennohi · 1 hour ago
                          Developer

                          @markeharding just fixed. sorry! :sweat_smile:

                        • Mark Harding @markeharding approved this merge request 2 minutes ago

                          approved this merge request

                        • Mark Harding @markeharding mentioned in commit 01c4ac21 2 minutes ago

                          mentioned in commit 01c4ac21

                        • Mark Harding @markeharding merged 2 minutes ago

                          merged

                        Please register or sign in to reply
                        0 Assignees
                        None
                        Misc. Q4 2019
                        Milestone
                        Misc. Q4 2019
                        Time tracking
                        No estimate or time spent
                        2
                        Labels
                        MR::Requires Changes Squad::Yellow
                        Lock merge request
                        Unlocked
                        10
                        10 participants
                        user avatar
                        Rami Albatal
                        user avatar
                        Ben Hayward
                        user avatar
                        Guy Thouret
                        user avatar
                        Emiliano Balbuena
                        user avatar
                        Martin Santangelo
                        user avatar
                        Olivia Madrid
                        user avatar
                        Brian Hatchet
                        Reference: minds/engine!380