Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 299
  • Merge Requests 40
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !369

Open
Opened 3 weeks ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/PinkPanther](fix): Cannot view paywalled content front#2004

Closes front#2004

Summary

Users could not view their own and others paywalled content. See the steps on the issue above and try it out for yourself.

Test

To test, I think we should test a variety of different media types, some with paywall and some without, from multiple accounts, and logged out, to ensure that everything is working.

Edited 3 days ago by Ben Hayward
Request to merge fix/media-paywall-2004 into master
The source branch is 64 commits behind the target branch
Open in Web IDE
Pipeline #89007449 passed for ed8d8021 on fix/media-paywall-2004
          Requires 3 more approvals from Devs, Deployers, and QA.
          Marcelo Rivera
          Marcelo Rivera
          Rami Albatal
          Rami Albatal
          Mark Harding
          Mark Harding
          Guy Thouret
          Guy Thouret
          Martin Santangelo
          Martin Santangelo
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Closes front#2004

          Deletes source branch

          • Discussion 1
          • Commits 1
          • Pipelines 1
          • Changes 3
          0/1 thread resolved
          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 3 weeks ago

            added scoped labels

          • Ben Hayward @benhayward.ben changed the description 3 weeks ago

            changed the description

          • Ben Hayward @benhayward.ben changed title from Sprint/PinkPanther: Cannot view paywalled content #2004 to Sprint/PinkPanther: Cannot view paywalled content front#2004 3 days ago

            changed title from : Cannot view paywalled content #2004 to : Cannot view paywalled content #2004

          • Ben Hayward @benhayward.ben changed the description 3 days ago

            changed the description

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 55 minutes ago
            Controllers/fs/v1/thumbnail.php
            18 18 exit;
            19 19 }
            20 20
            21 $featuresManager = new FeaturesManager;
            22
            23 if ($featuresManager->has('cdn-jwt')) {
            24 $signedUri = new Core\Security\SignedUri();
            25 $uri = (string) \Zend\Diactoros\ServerRequestFactory::fromGlobals()->getUri();
            26 if (!$signedUri->confirm($uri)) {
            27 exit;
            28 }
            21 $signedUri = new Core\Security\SignedUri();
            • Mark Harding
              Mark Harding @markeharding · 55 minutes ago
              Owner

              Public assets will not be signed to improve caching, so this check needs to be aware of that.

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 55 minutes ago

            added scoped label and automatically removed label

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Marcelo Rivera
          user avatar
          Rami Albatal
          user avatar
          Mark Harding
          user avatar
          Guy Thouret
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Olivia Madrid
          Reference: minds/engine!369