Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 799
  • Merge Requests 49
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !643

Open
Opened 5 days ago by Emiliano Balbuena@edgebal
Report abuse

(refactor): Remove engine logic from front/index.php

Testing

  • Open sandbox URL.
  • Ensure it works completely.

Might be best to test on staging or on a subdomain.

Issues

  • Closes #2216
Request to merge refactor/decouple-front-index into master
The source branch is 32 commits behind the target branch
Open in Web IDE
Pipeline #94169475 failed for c099ae3e on refactor/decouple-front-index
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Depends on 1 merge request being merged
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2216

              Deletes source branch

              • Discussion 1
              • Commits 1
              • Pipelines 1
              • Changes 1
              0/1 thread resolved
              • Emiliano Balbuena @edgebal added Product::Platform Squad::Yellow scoped labels 5 days ago

                added scoped labels

              • Emiliano Balbuena @edgebal mentioned in merge request engine!390 5 days ago

                mentioned in merge request engine!390

              • Emiliano Balbuena @edgebal mentioned in issue #2216 5 days ago

                mentioned in issue #2216

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 27 minutes ago
                src/index.php
                36 case strpos($name, ":") !== FALSE:
                37 echo "<meta property=\"$name\" content=\"$content\">\n";
                38 break;
                39 default:
                40 echo "<meta name=\"$name\" content=\"$content\">\n";
                41 }
                42 }
                43 ?>
                12 <?php echo $index->getMetaHtml() ?>
                44 13
                14 <title><?php echo $index->getTitle() ?></title>
                45 15
                46 16 <!-- inject:css -->
                47 17 <!-- endinject -->
                48 18
                49 <script>
                • Mark Harding
                  Mark Harding @markeharding · 27 minutes ago
                  Owner

                  this should still be in the HEAD to avoid waiting for page to fully load

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label 27 minutes ago

                added scoped label

              Please register or sign in to reply
              Assignee
              Emiliano Balbuena's avatar
              Emiliano Balbuena @edgebal
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              3
              Labels
              MR::Requires Changes Product::Platform Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Juan Manuel Solaro
              user avatar
              Marcelo Rivera
              user avatar
              Ben Hayward
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              Reference: minds/front!643