Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 799
  • Merge Requests 49
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !628

Merged
Opened 1 week ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/QuietQuail](fix): Avatar changing forms now change avatar without refresh of components

Closes #2197 (closed) #2087 (closed) #1835 (closed) and half of #2082

Testing

I think it'd be best to spin this up on a subdomain connected to live data, like revolver; so that it can be tested on the live site.

This makes changes to avatars site-wide, user avatars, and group avatars.

To test:

  1. Create a new account.
  2. Upload an avatar - check it updates everywhere.
  3. Create a comment on a post with current avatar.
  4. Change avatar.
  5. Create a second comment on a post, avatar on all comments should match current avatar of channel.
Edited 6 days ago by Xander Miller
Request to merge fix/avatar-change-detection-2197 into master
Pipeline #94745341 passed with warnings for 7d74b971 on fix/avatar-change-detection-2197
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller

              Merged by Mark Harding 17 minutes ago

              The changes were merged into master with 9e90087b

              The source branch has been deleted

              Closed #1835 (closed), #2087 (closed), and #2197 (closed)

              Mentions #2082

              Pipeline #95286643 running for 9e90087b on master
                            • Discussion 5
                            • Commits 8
                            • Pipelines 7
                            • Changes 3
                            1/1 thread resolved
                            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 week ago

                              added scoped labels

                            • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                              added 1 commit

                              • 631d2347 - Added docs and removed an unused import.

                              Compare with previous version

                            • Ben Hayward @benhayward.ben changed the description 1 week ago

                              changed the description

                            • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                              added 1 commit

                              • 908ebf3f - Changed service encapsulation for use in template

                              Compare with previous version

                            • Mark Harding
                              Mark Harding @markeharding started a thread on an old version of the diff 1 week ago
                              Resolved by Ben Hayward 1 week ago
                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 week ago

                              added scoped label and automatically removed label

                            • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                              added 1 commit

                              • f5118c96 - Refactored and got rid of account switching bug

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 week ago

                              added scoped label and automatically removed label

                            • Ben Hayward @benhayward.ben resolved all threads 1 week ago

                              resolved all threads

                            • Ben Hayward @benhayward.ben resolved all threads 1 week ago

                              resolved all threads

                            • Mark Harding
                              Mark Harding @markeharding · 6 days ago
                              Owner

                              After login, I no longer have an avatar on the topbar Screenshot_2019-11-05_at_10.05.47.

                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 6 days ago

                              added scoped label and automatically removed label

                            • Mark Harding
                              Mark Harding @markeharding · 6 days ago
                              Owner

                              Appears to be a change detection issue.

                            • Xander Miller @xander-miller mentioned in merge request engine!386 (merged) 6 days ago

                              mentioned in merge request engine!386 (merged)

                            • Xander Miller
                              Xander Miller @xander-miller · 6 days ago
                              Developer

                              Comment avatars should match current avatar not avatar when comment was made.

                              image

                            • Xander Miller @xander-miller changed the description 6 days ago

                              changed the description

                            • Ben Hayward @benhayward.ben added 1 commit 5 days ago

                              added 1 commit

                              • 8871491e - Updated to account for session switching

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added 1 commit 5 days ago

                              added 1 commit

                              • e169b919 - Noticed error

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added 64 commits 3 days ago

                              added 64 commits

                              • e169b919...9cb3a5b1 - 62 commits from branch master
                              • 8565bdfa - Merge branch 'master' of gitlab.com:minds/front into fix/avatar-change-detection-2197
                              • 7d74b971 - Initialize observable at creation

                              Compare with previous version

                            • Mark Harding @markeharding approved this merge request 17 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding merged 17 minutes ago

                              merged

                            • Mark Harding @markeharding mentioned in commit 9e90087b 17 minutes ago

                              mentioned in commit 9e90087b

                            Please register or sign in to reply
                            0 Assignees
                            None
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Requires Changes Squad::Yellow
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Martin Santangelo
                            user avatar
                            Guy Thouret
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Olivia Madrid
                            user avatar
                            Brian Hatchet
                            Reference: minds/front!628