Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 801
  • Merge Requests 50
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !645

Open
Opened 5 days ago by Ben Hayward@benhayward.ben
Report abuse

Preferred hashtag remembered in local storage #1366

Closes #1302 (closed)

Test that your selection for preferred is remembered in local storage.

  1. Set it to on
  2. Tab over to wallet or another page
  3. Refresh
  4. Visit discovery - it should have remembered the state was on.
  5. Turn it off, and repeat to confirm that is remembers the 'off' state
Request to merge feat/default-disc-tags-1366 into master
The source branch is 37 commits behind the target branch
Open in Web IDE
Pipeline #94440757 failed for 15db3ac9 on feat/default-disc-tags-1366
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1302 (closed)

              Mentions #1366 (closed)

              Deletes source branch

              • Discussion 2
              • Commits 2
              • Pipelines 2
              • Changes 2
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 5 days ago

                added scoped labels

              • Ben Hayward @benhayward.ben added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 5 days ago

                added scoped label and automatically removed label

              • Mark Harding
                Mark Harding @markeharding · 4 days ago
                Owner

                This is now no longer defaulting to preferred by default.

              • Ben Hayward @benhayward.ben added 1 commit 4 days ago

                added 1 commit

                • 15db3ac9 - Default to true

                Compare with previous version

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 4 days ago

                added scoped label and automatically removed label

              • Mark Harding
                Mark Harding @markeharding · 12 minutes ago
                Owner

                Still issues here @benhayward.ben.

                Screen_Shot_2019-11-12_at_9.18.40_AM

                The XHR request is returning preferred when it should be all.

              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 12 minutes ago

                added scoped label and automatically removed label

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Marcelo Rivera
              user avatar
              Juan Manuel Solaro
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              user avatar
              Guy Thouret
              user avatar
              Emiliano Balbuena
              user avatar
              Olivia Madrid
              Reference: minds/front!645