Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 801
  • Merge Requests 50
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !649

Open
Opened 4 days ago by Ben Hayward@benhayward.ben
Report abuse

Adjusted dropdown menus to have a larger clickable area #2223

Let me know what you think of this approach @markeharding.

It was majorly awkward because there are multiple places that these classes are used.

image

image

Testing

Find dropdowns and check they're not broken - note some dropdowns like the discovery are horizontal.

Request to merge fix/dropdown-item-padding-2223 into master
The source branch is 15 commits behind the target branch
Open in Web IDE
Pipeline #94430943 passed with warnings for d9a35b88 on fix/dropdown-item-padding-2223
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Mentions #2223 (closed)

              Deletes source branch

              • Discussion 1
              • Commits 1
              • Pipelines 1
              • Changes 4
              0/1 thread resolved
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 4 days ago

                added scoped labels

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 10 minutes ago
                src/app/common/components/dropdown/dropdown.component.scss
                92 96 border: 1px solid themed($m-grey-50);
                93 97 }
                94 98
                99 .m-dropdown--list--item {
                • Mark Harding
                  Mark Harding @markeharding · 10 minutes ago
                  Owner

                  why is padding not applied to bem styled .m-dropdownList__item?

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 10 minutes ago

                added scoped label and automatically removed label

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Marcelo Rivera
              user avatar
              Juan Manuel Solaro
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              user avatar
              Guy Thouret
              user avatar
              Emiliano Balbuena
              user avatar
              Olivia Madrid
              Reference: minds/front!649