Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 804
  • Merge Requests 51
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !651

Open
Opened 19 hours ago by Emiliano Balbuena@edgebal
Report abuse

(fix): Mass NSFW XHR trigger when admins view posts

Testing

  • Log in as an admin
  • Open Dev Tools > Network
  • Reload the page (IMPORTANT STEP)
  • Visit a channel that has posts (the more, the better)
  • Ensure there are NO XHR requests to /v2/admin/nsfw/<numeric_value>

Issues

  • Closes #2231.
Edited 19 hours ago by Emiliano Balbuena
Request to merge hotfix/mass-nsfw-xhr-bug into master
Open in Web IDE
Pipeline #95114819 passed with warnings for 9de57d28 on hotfix/mass-nsfw-xhr-bug
              Requires 3 more approvals from Devs, Deployers, and QA.
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Deletes source branch

              • Discussion 1
              • Commits 4
              • Pipelines 3
              • Changes 8
              0/1 thread resolved
              • Emiliano Balbuena @edgebal added Product::Platform Squad::Yellow scoped labels 19 hours ago

                added scoped labels

              • Emiliano Balbuena @edgebal changed the description 19 hours ago

                changed the description

              • Emiliano Balbuena @edgebal added 4 commits 18 hours ago

                added 4 commits

                • 835d6913...e5e50c2b - 2 commits from branch master
                • a6727572 - Merge remote-tracking branch 'origin/master' into hotfix/mass-nsfw-xhr-bug
                • cb2efedd - (cs): Lint

                Compare with previous version

              • Emiliano Balbuena @edgebal added 1 commit 17 hours ago

                added 1 commit

                • 9de57d28 - (cs): Lint (ii)

                Compare with previous version

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 9 minutes ago
                src/app/common/components/post-menu/post-menu.component.ts
                345 345 }
                346 346
                347 347 onNSFWSelected(reasons: Array<{ label; value; selected }>) {
                348 console.log('yo');
                • Mark Harding
                  Mark Harding @markeharding · 9 minutes ago
                  Owner

                  :eyes:

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label 9 minutes ago

                added scoped label

              Please register or sign in to reply
              Assignee
              Emiliano Balbuena's avatar
              Emiliano Balbuena @edgebal
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              3
              Labels
              MR::Requires Changes Product::Platform Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Marcelo Rivera
              user avatar
              Juan Manuel Solaro
              user avatar
              Ben Hayward
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              user avatar
              Guy Thouret
              user avatar
              Olivia Madrid
              Reference: minds/front!651