Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 802
  • Merge Requests 50
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !631

Merged
Opened 3 days ago by Emiliano Balbuena@edgebal
Report abuse

(feat): Show "log in to comment" when logged out

Testing

Empty comments box

  • Create a new post in the newsfeed and copy the URL
  • Log out and paste the URL
  • A Log in to comment link should show up
  • Click on LOGIN and enter creds
  • Page will be refreshed and comment composer should show up

Threaded comments box

  • (using the post from the previous testing case)
  • Add a comment
  • Reply to that same comment to create a thread
  • Log out and paste the URL
  • A Log in to comment link should show up on the root level
  • Nothing should show up on the thread
  • Click on LOGIN and enter creds
  • Page will be refreshed and comment composer should show up on both root and thread levels

Group conversation

  • Create (or go to) a public group, copy the URL
  • Logout and paste the URL
  • A Log in to send a message link should show up
  • Click on LOGIN and enter creds
  • Page will be refreshed and message composer should show up

Issues

  • Closes #2052 (closed).
Request to merge goal/log-in-notice-comment-thread into master
Pipeline #94347466 passed with warnings for 266bb434 on goal/log-in-notice-comment-thread
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Xander Miller
              Xander Miller
              Brian Hatchet
              Brian Hatchet

              Merged by Mark Harding 1 day ago

              The changes were merged into master with 9cb3a5b1

              The source branch has been deleted

              Closed #2052 (closed)

              Pipeline #94644362 passed for 9cb3a5b1 on master
                            • Discussion 3
                            • Commits 3
                            • Pipelines 2
                            • Changes 7
                            • Emiliano Balbuena @edgebal added Sprint::10/23 - Quiet Quail scoped label 3 days ago

                              added scoped label

                            • Mark Harding @markeharding added MR::Ready to Merge scoped label 2 days ago

                              added scoped label

                            • Mark Harding @markeharding approved this merge request 2 days ago

                              approved this merge request

                            • Mark Harding @markeharding assigned to @ottman, @jotto141, and @xander-miller 2 days ago

                              assigned to @ottman, @jotto141, and @xander-miller

                            • Mark Harding @markeharding unapproved this merge request 2 days ago

                              unapproved this merge request

                            • Mark Harding
                              Mark Harding @markeharding · 2 days ago
                              Owner

                              @edgebal When clicking from a modal, the login modal shows behind the media modal.

                            • Emiliano Balbuena @edgebal added 21 commits 2 days ago

                              added 21 commits

                              • 34c3727b...b8faccdb - 19 commits from branch master
                              • f43130b5 - Merge remote-tracking branch 'origin/master' into goal/log-in-notice-comment-thread
                              • 266bb434 - (fix): Modal z-index on minds.com; stop click bubbling

                              Compare with previous version

                            • Xander Miller @xander-miller approved this merge request 1 day ago

                              approved this merge request

                            • Xander Miller
                              Xander Miller @xander-miller · 1 day ago
                              Developer

                              Thanks for the concise testing instructions @edgebal very useful. :100:

                            • Mark Harding @markeharding approved this merge request 1 day ago

                              approved this merge request

                            • Mark Harding @markeharding merged 1 day ago

                              merged

                            • Mark Harding @markeharding mentioned in commit 9cb3a5b1 1 day ago

                              mentioned in commit 9cb3a5b1

                            • Bill Ottman
                              Bill Ottman :dragon_face: @ottman · 7 minutes ago
                              Owner

                              where do i test this?

                            Please register or sign in to reply
                            4 Assignees
                            Emiliano Balbuena's avatar
                            Bill Ottman's avatar
                            Jack Ottman's avatar
                            Xander Miller's avatar
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Ready to Merge Sprint::10/23 - Quiet Quail
                            Lock merge request
                            Unlocked
                            12
                            12 participants
                            user avatar
                            Guy Thouret
                            user avatar
                            Olivia Madrid
                            user avatar
                            Martin Santangelo
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Brian Hatchet
                            user avatar
                            Ben Hayward
                            Reference: minds/front!631