[Sprint/RollingRabbit](fix): Removed encryption exception - Sentry - #1099
Testing Hit {{host}}/api/v2/messenger/keys?cb=1573153203597&password=
Request to merge
fix/encryption-error-sentry-1099
into
master
The source branch is 4 commits behind the target branch
0/1
thread resolved
added scoped labels
![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
Last updated by Mark Harding110 110 { 111 111 $private_key = openssl_get_privatekey($private_key, $password); 112 112 if (!$private_key) { 113 throw new \Exception('Could not decrypt private key'); 113 return [ - Owner
The Controller should be returning the response, not core function.
DeveloperThe controller is returning a response of its own. This felt right to me incase any other classes implement this file.
Can easily make this error the one returned though.
- Owner
An exception is appropriate, it just needs to be be caught before it hits the api.
added scoped label and automatically removed label
