Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 294
  • Merge Requests 40
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !392

Open
Opened 20 hours ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/RollingRabbit](fix): Removed encryption exception - Sentry - #1099

Testing Hit {{host}}/api/v2/messenger/keys?cb=1573153203597&password=

Request to merge fix/encryption-error-sentry-1099 into master
The source branch is 4 commits behind the target branch
Open in Web IDE
Pipeline #94470568 failed for 42626c83 on fix/encryption-error-sentry-1099
          Requires 3 more approvals from Devs, Deployers, and QA.
          Emiliano Balbuena
          Emiliano Balbuena
          Guy Thouret
          Guy Thouret
          Martin Santangelo
          Martin Santangelo
          Rami Albatal
          Rami Albatal
          Mark Harding
          Mark Harding
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Mentions #1099

          Deletes source branch

          • Discussion 3
          • Commits 2
          • Pipelines 2
          • Changes 1
          0/1 thread resolved
          • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 20 hours ago

            added scoped labels

          • Ben Hayward @benhayward.ben added 1 commit 20 hours ago

            added 1 commit

            • 42626c83 - Lint

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 3 hours ago
            Last updated by Mark Harding 12 minutes ago
            Core/Messenger/Encryption/OpenSSL.php
            110 110 {
            111 111 $private_key = openssl_get_privatekey($private_key, $password);
            112 112 if (!$private_key) {
            113 throw new \Exception('Could not decrypt private key');
            113 return [
            • Mark Harding
              Mark Harding @markeharding · 3 hours ago
              Owner

              The Controller should be returning the response, not core function.

            • Ben Hayward
              Ben Hayward @benhayward.ben · 2 hours ago
              Developer

              The controller is returning a response of its own. This felt right to me incase any other classes implement this file.

              Can easily make this error the one returned though.

            • Mark Harding
              Mark Harding @markeharding · 12 minutes ago
              Owner

              An exception is appropriate, it just needs to be be caught before it hits the api.

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 3 hours ago

            added scoped label and automatically removed label

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Guy Thouret
          user avatar
          Martin Santangelo
          user avatar
          Rami Albatal
          user avatar
          Mark Harding
          user avatar
          Brian Hatchet
          user avatar
          Olivia Madrid
          Reference: minds/engine!392