Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project overview
  • Repository
  • Issues 233
  • Merge Requests 10
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !387

Merged
Opened 1 month ago by Martin Santangelo@msantang7825 of 25 tasks completed25/25 tasks
Report abuse

Permissions EPIC

  • Implement permissions check in the base model
  • Implement permissions in the activity action sheet
  • Optimize activity action sheet to check permission only when is opened.
  • Move comments action sheet to another component (from Comment)
  • Implement permissions in comment actions sheet
  • Implement permissions in channel actions
  • Implement permissions in comments list
  • (chore) update mobx
  • Improve blog card component
  • Improve blog view screen actions styling (vote and remind buttons)
  • Implement permissions in vote actions
  • Implement permissions in remind action
  • Implement FLAG_APPOINT_MODERATOR check in groups
  • Implement permission into the groups post creator
  • Implement JOIN_GATHERING check
  • Add default warning message for denied permissions
  • Implement FLAG_VIEW check
  • Implement open/moderated/closed channel mode selector
  • Deny access to closed channels
  • Implement request subscriptions list in user's channel
  • Implement request subscriptions deny/accept
  • Handle 403 response on entities and channels services
  • Fix broken tests
  • Implement MESSAGE check
  • Implement new spec test for permissions

closes #1445 closes #1397 closes #1441 closes #1440 closes #1438 closes #1048 closes #1049 closes #1435 closes #1050 closes #1437 closes #1351
closes #1413 closes #1356 closes #1193 closes #2030 closes #1385 closes #1378 closes #1414 closes #1350 closes #1191 closes #1192 closes #1395 closes #1390 closes #1382 closes #1391 closes #1393 closes #1354

Edited 2 hours ago by Martin Santangelo
Request to merge feat/permissions-implementation-model-activitysheet-channels into release/3.11.0
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Requires 2 more approvals.

Merged by Martin Santangelo 2 hours ago

The changes were merged into release/3.11.0 with 26153003

Pipeline #94495001 failed for 26153003 on release/3.11.0
          • Discussion 0
          • Commits 65
          • Pipelines 24
          • Changes 92
          • Martin Santangelo @msantang78 added Sprint::09/25 - Oldfashioned Owl Squad::Green scoped labels 1 month ago

            added scoped labels

          • Martin Santangelo @msantang78 added 5 commits 1 month ago

            added 5 commits

            • 9047e346 - (chore) update mobx
            • 8875cda1 - (feat) implement permissions in channel actions
            • bb32f954 - (feat) move comment action sheet to another component
            • 2cf317f2 - (feat) implement permissions in activity actions sheet
            • 7289a830 - (feat) implement permissions and improve comments list code

            Compare with previous version

            Toggle commit list
          • Martin Santangelo @msantang78 changed the description 1 month ago

            changed the description

          • Martin Santangelo @msantang78 added 2 commits 1 month ago

            added 2 commits

            • e9387aef - (chore) update test snapshots
            • 7726bbd0 - (feat) fix channel actions spec test

            Compare with previous version

          • Martin Santangelo @msantang78 changed the description 1 month ago

            changed the description

          • Martin Santangelo @msantang78 changed the description 1 month ago

            changed the description

          • Martin Santangelo @msantang78 added 8 commits 1 month ago

            added 8 commits

            • cfe9e76e - (feat) Blog Card improvement and FLAG_VIEW enfoce
            • 0cae9596 - (feat) improve blog screen action buttons
            • dea0b6bc - (feat) improve blog list separator
            • 9ab0b8c7 - (feat) enforce FLAG_VOTE in thumb actions
            • 9768db94 - (feat) enforce FLAG_CREATE_COMMENT in comment list
            • feb1b5bd - (feat) enforce FLAG_REMIND in remind action and code clean up
            • f2138791 - (feat) show comments action as disabled for FLAG_CREATE_COMMENT
            • 23f59a1c - (feat) counter component code clean up

            Compare with previous version

            Toggle commit list
          • Martin Santangelo @msantang78 changed title from WIP: Permissions implemented in ActivityActionsheet and ChannelActions to WIP: Permissions EPIC 1 month ago

            changed title from WIP: Permissions to WIP: Permissions

          • Martin Santangelo @msantang78 changed the description 1 month ago

            changed the description

          • Martin Santangelo @msantang78 changed the description 1 month ago

            changed the description

          • Martin Santangelo @msantang78 changed the description 4 weeks ago

            changed the description

          • Martin Santangelo @msantang78 added 4 commits 4 weeks ago

            added 4 commits

            • db0c0c4f - (feat) enforce FLAG_CREATE_POST into groups screen
            • 8c6f8a99 - (feat) enforce FLAG_SUBSCRIBE into user list component
            • 971dc3e7 - (feat) enforce JOIN and JOIN_GATHERING
            • 0cb040c1 - (feat) enforce FLAG_APPOINT_MODERATOR in groups

            Compare with previous version

            Toggle commit list
          • Martin Santangelo @msantang78 changed the description 4 weeks ago

            changed the description

          • Martin Santangelo @msantang78 added 10 commits 4 weeks ago

            added 10 commits

            • ba6e7e22 - (feat) add optional default alert messages to the permission check method
            • 0ac310b8 - (feat) show permission alert in thumb actions
            • ae8388d4 - (feat) add FLAG_VIEW check to discovery user component
            • 24055625 - (feat) add FLAG_VIEW check to channel screen
            • d922dc46 - (feat) show a message if the user doesn't have permission to remind
            • e078f063 - (feat) show a message if the user doesn't have permission to view a blog
            • fb59ab8f - (feat) add FLAG_VIEW check to activity screen
            • 89afea71 - (feat) add FLAG_JOIN check to groups list item
            • 933188d4 - (feat) log errors in single entity store
            • 3d14508b - (feat) remove arrow functions from discovery screen to improve performance

            Compare with previous version

            Toggle commit list
          • Martin Santangelo @msantang78 changed the description 4 weeks ago

            changed the description

          • Martin Santangelo @msantang78 added 5 commits 4 weeks ago

            added 5 commits

            • 50d4a8f3 - (feat) add FLAG_VIEW check and code cleaning in group screen
            • f50f9a4d - (feat) add FLAG_VIEW check to groups in the discovery screen
            • 4212fd06 - (feat) add FLAG_VIEW check in blog view screen
            • 401ccd09 - (fix) gathering service FLAG_JOIN_GATHERING check
            • 28c29bf8 - (feat) permissions behind a feature flag

            Compare with previous version

            Toggle commit list
          • Martin Santangelo @msantang78 marked the task Implement FLAG_VIEW check as completed 4 weeks ago

            marked the task Implement FLAG_VIEW check as completed

          • Martin Santangelo @msantang78 added 1 commit 4 weeks ago

            added 1 commit

            • ba34258c - (fix) channel screen should react to permissions load

            Compare with previous version

          • Martin Santangelo @msantang78 added 5 commits 3 weeks ago

            added 5 commits

            • b854aa6d - (feat) add open/close logic to UserModel
            • b43773c8 - (fix) invariant violation Text strings must be rendered within a Text component
            • 69d92731 - (feat) implement open/closed channel
            • 1892c2ed - (feat) do not log network fail, aborts, etc
            • ec1cafd9 - (chore) remove unused import

            Compare with previous version

            Toggle commit list
          • Martin Santangelo @msantang78 added 1 commit 3 weeks ago

            added 1 commit

            • 8fc0005e - (feat) force APPROVE_SUBSCRIBER in channel

            Compare with previous version

          • Martin Santangelo @msantang78 added 1 commit 3 weeks ago

            added 1 commit

            • 1b2880c9 - (feat) implement channel mode selector

            Compare with previous version

          • Martin Santangelo @msantang78 added 4 commits 3 weeks ago

            added 4 commits

            • 439da802 - (feat) update date picker package
            • 7a8d666d - (feat) language file new terms for open/closed channels
            • d57feae2 - (feat) fix spec broken spec tests
            • 2a03ec56 - (feat) flow es class settings

            Compare with previous version

            Toggle commit list
          • Martin Santangelo @msantang78 marked the task Fix broken tests as completed 3 weeks ago

            marked the task Fix broken tests as completed

          • Martin Santangelo @msantang78 added 4 commits 3 weeks ago

            added 4 commits

            • d5107cca - (fix) channel's subscribers list error
            • e070dcb9 - (fix) groups member list error
            • c2175c9e - (chore) update test snapshot
            • b3632a95 - (feat) log errors on feed store's refresh

            Compare with previous version

            Toggle commit list
          • Martin Santangelo @msantang78 changed the description 3 weeks ago

            changed the description

          • Martin Santangelo @msantang78 changed milestone to %Mobile 3.11 3 weeks ago

            changed milestone to %Mobile 3.11

          • Martin Santangelo @msantang78 added 1 commit 3 weeks ago

            added 1 commit

            • 7ad581c4 - (fix) activity delete option is not working

            Compare with previous version

          • Martin Santangelo @msantang78 added 2 commits 3 weeks ago

            added 2 commits

            • 1452f069 - (feat) ignore aborts on log service exception handling
            • 04b7da57 - (feat) handle 403 in entity service, delete cache and react in UI

            Compare with previous version

          • Martin Santangelo @msantang78 added 1 commit 3 weeks ago

            added 1 commit

            • 623619db - (fix) activity screen spec test

            Compare with previous version

          • Martin Santangelo @msantang78 added 1 commit 3 weeks ago

            added 1 commit

            • 661d4b54 - (feat) handle 403 responses on channels service

            Compare with previous version

          • Martin Santangelo @msantang78 changed the description 3 weeks ago

            changed the description

          • Martin Santangelo @msantang78 added 1 commit 3 weeks ago

            added 1 commit

            • b07ad242 - (fix) channel screen show alert twice if view permission is removed

            Compare with previous version

          • Martin Santangelo @msantang78 added 2 commits 3 weeks ago

            added 2 commits

            • 8e4e62c2 - (feat) test base model permissions can method
            • 27168e50 - (feat) spec test closed channels and async view permission lose on channels screen

            Compare with previous version

          • Martin Santangelo @msantang78 added 1 commit 3 weeks ago

            added 1 commit

            • e4efb208 - (feat) async check view permission in group and blog screens

            Compare with previous version

          • Martin Santangelo @msantang78 added 56 commits 1 day ago

            added 56 commits

            • e4efb208...64f72980 - 55 commits from branch release/3.11.0
            • 6bc3e382 - Merge branch 'release/3.11.0' into feat/permissions-implementation-model-activitysheet-channels

            Compare with previous version

          • Martin Santangelo @msantang78 added 2 commits 9 hours ago

            added 2 commits

            • 1a1f160e - (feat) check FLAG_MESSAGE in messenger conversations
            • 72ce7f5e - (chore) update spec snapshot

            Compare with previous version

          • Martin Santangelo @msantang78 marked the task Implement MESSAGE check as completed 3 hours ago

            marked the task Implement MESSAGE check as completed

          • Martin Santangelo @msantang78 marked the task Implement new spec test for permissions as completed 3 hours ago

            marked the task Implement new spec test for permissions as completed

          • Martin Santangelo @msantang78 added 23 commits 3 hours ago

            added 23 commits

            • 72ce7f5e...6aa3ace3 - 22 commits from branch release/3.11.0
            • 8a2b74ce - Merge branch 'release/3.11.0' into feat/permissions-implementation-model-activitysheet-channels

            Compare with previous version

          • Juan Manuel Solaro @juanmsolaro approved this merge request 2 hours ago

            approved this merge request

          • Martin Santangelo @msantang78 unmarked as a Work In Progress 2 hours ago

            unmarked as a Work In Progress

          • Martin Santangelo @msantang78 changed the description 2 hours ago

            changed the description

          • Martin Santangelo @msantang78 added 4 commits 2 hours ago

            added 4 commits

            • 8a2b74ce...83cd63c2 - 3 commits from branch release/3.11.0
            • 78f22698 - Merge branch 'release/3.11.0' into feat/permissions-implementation-model-activitysheet-channels

            Compare with previous version

          • Martin Santangelo @msantang78 merged 2 hours ago

            merged

          Please register or sign in to reply
          0 Assignees
          None
          Mobile 3.11
          Milestone
          Mobile 3.11
          Time tracking
          No estimate or time spent
          2
          Labels
          Sprint::09/25 - Oldfashioned Owl Squad::Green
          Lock merge request
          Unlocked
          2
          2 participants
          user avatar
          Martin Santangelo
          user avatar
          Juan Manuel Solaro
          Reference: minds/mobile-native!387