Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project overview
  • Repository
  • Issues 231
  • Merge Requests 12
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !390

Merged
Opened 4 weeks ago by Juan Manuel Solaro@juanmsolaro
Report abuse

[Sprint/OldfashionedOwl] (fix) shouldBeBlured is not a function

I couldn't reproduce consistently. From discovery, when trying to open an activity, sometimes, gives silent error in console.

Request to merge fix/shouldBeBlured-is-not-a-function into release/3.11.0
Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.
Merge request approved. Approved by
Emiliano Balbuena
Emiliano Balbuena
Martin Santangelo
Martin Santangelo

Merged by Martin Santangelo 12 minutes ago

The changes were merged into release/3.11.0 with ccfe9281

Pipeline #94484036 failed for ccfe9281 on release/3.11.0
          • Discussion 1
          • Commits 3
          • Pipelines 2
          • Changes 2
          0/1 thread resolved
          • Martin Santangelo
            Martin Santangelo @msantang78 started a thread on an old version of the diff 4 weeks ago
            Last updated by Juan Manuel Solaro 6 hours ago
            src/newsfeed/activity/Activity.js
            69 70 * Render
            70 71 */
            71 72 render() {
            72 const entity = this.props.entity;
            73 const entity = ActivityModel.isActivity(this.props.entity) ? this.props.entity : ActivityModel.create(this.props.entity);
            • Martin Santangelo
              Martin Santangelo @msantang78 · 4 weeks ago
              Maintainer

              I already created a method checkOrCreate() in the BaseModel so you can call directly ActivityModel.checkOrCreate(entity)

              Edited by Martin Santangelo 4 weeks ago
            • Juan Manuel Solaro @juanmsolaro changed this line in version 2 of the diff 6 hours ago

              changed this line in version 2 of the diff

            • Please register or sign in to reply
          • Juan Manuel Solaro @juanmsolaro added 47 commits 6 hours ago

            added 47 commits

            • 608df5b0...64f72980 - 45 commits from branch release/3.11.0
            • 781d2b8d - (fix) use checkOrCreate instead of isActivity
            • 2b453ca0 - Merge remote-tracking branch 'upstream/release/3.11.0' into fix/shouldBeBlured-is-not-a-function

            Compare with previous version

          • Martin Santangelo @msantang78 approved this merge request 4 hours ago

            approved this merge request

          • Emiliano Balbuena @edgebal approved this merge request 3 hours ago

            approved this merge request

          • Martin Santangelo @msantang78 merged 12 minutes ago

            merged

          • Martin Santangelo @msantang78 mentioned in commit ccfe9281 12 minutes ago

            mentioned in commit ccfe9281

          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Lock merge request
          Unlocked
          3
          3 participants
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Juan Manuel Solaro
          Reference: minds/mobile-native!390