Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 803
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 53
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #1916

Closed
Open
Opened 1 month ago by Mark Edworthy@medworthy
Report abuse New issue

Accessibility to locked blog articles

Summary

With reference to a recent H&S enquiry, I have tested an example blog article and found that whilst not purchasing access to locked articles, I am able to copy and paste the obscured text content of said locked article into external text editors and word processor applications.

The example blog article also contains video content (provided via the YouTube bridge) in which the audio content can be listened to whilst the article is locked.

Steps to reproduce

View a blog article whilst it is locked (ie. needing a predetermined amount of tokens to be able to access said content) and then attempt to listening to any video / audio content, as well as attempting to copy the text content to an external application.

Platform information

I believe that this is user platform neutral. However, I have tested this whilst using Firefox (x86_64 version 68.0.2) and Chromium (x86_64 version 76.0.3809).

What is the current bug behavior?

See above

What is the expected correct behavior?

Locked content should not be accessible to the user (until the user purchases access to said content).

Relevant logs and/or screenshots

Reference:

  • Original Help And Support Enquiry
    https://www.minds.com/newsfeed/1020105341986635776

  • Example Blog Article
    https://www.minds.com/cellblock07208/blog/from-the-pulpit-my-beginnings-with-religion-1019970882463047680

Edited 1 month ago by Mark Edworthy

Related issues
0

Related merge requests
2
  • [Sprint/OldfashionedOwl](fix): Hiding blog content when paywall not met. #1916
    !573
  • [Sprint/PinkPanther](fix): Stripping out blog body upon export.
    engine !359
When these merge requests are accepted, this issue will be closed automatically.
  • Discussion 8
  • Designs 0
  • Mark Edworthy @medworthy changed the description 3 times within 10 minutes 1 month ago

    changed the description 3 times within 10 minutes

  • Mark Edworthy @medworthy changed the description 1 month ago

    changed the description

  • Mark Edworthy @medworthy changed title from Accessability to locked blog articles to Accessibility to locked blog articles 1 month ago

    changed title from Accessbility to locked blog articles to Accessbility to locked blog articles

  • Mark Edworthy @medworthy changed the description 1 month ago

    changed the description

  • Ben Hayward @benhayward.ben assigned to @benhayward.ben 1 month ago

    assigned to @benhayward.ben

  • Ben Hayward @benhayward.ben added Priority::1 - High Product::Blogs Type::Bug scoped labels 1 month ago

    added scoped labels

  • Ben Hayward @benhayward.ben added Sprint::09/11 - Nuanced Numbat scoped label 1 month ago

    added scoped label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 1 month ago
    Developer

    Thanks for highlighting this @medworthy. Moved into this sprint; may be delayed to next sprint depending how I get through my existing jobs.

    Edited by Ben Hayward 1 month ago
  • Ben Hayward @benhayward.ben added Sprint::09/25 - Oldfashioned Owl scoped label and automatically removed Sprint::09/11 - Nuanced Numbat label 1 month ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben changed time estimate to 5h 1 month ago

    changed time estimate to 5h

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label 1 month ago

    added scoped label

  • Ben Hayward @benhayward.ben mentioned in commit 26eb97c2 1 month ago

    mentioned in commit 26eb97c2

  • Ben Hayward @benhayward.ben mentioned in merge request !573 (closed) 1 month ago

    mentioned in merge request !573 (closed)

  • Ben Hayward @benhayward.ben added 2h 30m of time spent at 2019-09-25 1 month ago

    added 2h 30m of time spent at 2019-09-25

  • Ben Hayward @benhayward.ben added Status::Review scoped label and automatically removed Status::InProgress label 1 month ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben changed weight to 1 1 month ago

    changed weight to 1

  • Ben Hayward @benhayward.ben assigned to @edgebal 1 month ago

    assigned to @edgebal

  • Ben Hayward @benhayward.ben added Squad::Yellow scoped label 1 month ago

    added scoped label

  • Mark Harding
    Mark Harding @markeharding · 1 month ago
    Owner

    @benhayward.ben what is the status of this task?

  • Mark Harding @markeharding unassigned @edgebal 1 month ago

    unassigned @edgebal

  • Mark Harding @markeharding added Sprint::10/09 - Pink Panther Status::Backlog scoped labels and automatically removed Sprint::09/25 - Oldfashioned Owl Status::Review labels 4 weeks ago

    added scoped labels and automatically removed labels

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label and automatically removed Status::Backlog label 4 weeks ago

    added scoped label and automatically removed label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 4 weeks ago
    Developer

    My investigation revealed to me like the ACL is not firing correctly. I suspect https://gitlab.com/minds/engine/blob/abacfb66bb1bcbc616c81761835ada048c7723ac/Core/Wire/Paywall/Events.php to be at fault, this was assigned over to Emi at his request but happy to take a further look.

  • Ben Hayward
    Ben Hayward @benhayward.ben · 4 weeks ago
    Developer

    https://gitlab.com/minds/engine/blob/e2f62b2e3845b29123b5c280bd2a2c2edc3357f0/Core/Blogs/Blog.php

    In _extendExport, $this->_eventsDispatcher->trigger('export:extender', 'blog', [ 'entity' => $this ], []) is never reached, as _extendExport is never called, so the subsequent export:extender does not trigger, which should be stripping out the body from the blog.

    If I change the function signature of _extendExport($export) to export() The body data is stripped, still doesn't load though. I can't find any calls to _extendExport($export). So to me, this implies some part of the system is expecting export() to be in the blog function.

  • Ben Hayward @benhayward.ben added 3h of time spent at 2019-10-09 4 weeks ago

    added 3h of time spent at 2019-10-09

  • Ben Hayward @benhayward.ben added Status::Follow Up scoped label and automatically removed Status::InProgress label 4 weeks ago

    added scoped label and automatically removed label

  • Ben Hayward @benhayward.ben added Status::InProgress scoped label and automatically removed Status::Follow Up label 4 weeks ago

    added scoped label and automatically removed label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 4 weeks ago
    Developer

    $this->_eventsDispatcher->trigger('export:extender', 'blog', \[ 'entity' => $this \], \[\]) Infact is reached, and isn't read upon being registered.

  • Ben Hayward @benhayward.ben added Status::Review scoped label and automatically removed Status::InProgress label 4 weeks ago

    added scoped label and automatically removed label

  • Ben Hayward
    Ben Hayward @benhayward.ben · 4 weeks ago
    Developer

    Overspent time on this, had gotten to a few solutions, but they were all quite hacky workarounds. Seems to be something weird going on when the event is not registered. I think this one maybe could still be considered a workaround, but isn't so hacky as I think the blog namespace is a valid place to store blog paywall logic.

    Still there is an underlying issue in that the old code was not registering.

  • Ben Hayward @benhayward.ben added 3h 30m of time spent at 2019-10-10 4 weeks ago

    added 3h 30m of time spent at 2019-10-10

  • Ben Hayward @benhayward.ben mentioned in issue #2080 (closed) 3 weeks ago

    mentioned in issue #2080 (closed)

  • Xander Miller
    Xander Miller @xander-miller · 3 weeks ago
    Developer

    When this bug is resolved @javanick Should follow up with minds::@cellblock07208 and minds::@medworthy to thank them and tell them it's fixed.

  • Ben Hayward
    Ben Hayward @benhayward.ben · 3 weeks ago
    Developer

    engine!359 (diffs)

  • Ben Hayward @benhayward.ben closed 12 minutes ago

    closed

Please register or sign in to reply
Assignee
Ben Hayward's avatar
Ben Hayward @benhayward.ben
none
Epic
None
None
Milestone
None
Time tracking
Spent 1d 1h
Est 5h
None
Due date
None
6
Labels
Priority::1 - High Product::Blogs Sprint::10/09 - Pink Panther Squad::Yellow Status::Review Type::Bug
1
Weight
1
Confidentiality
Not confidential
Lock issue
Unlocked
6
6 participants
user avatar
Ben Hayward
user avatar
Xander Miller
user avatar
Mark Edworthy
user avatar
Mark Harding
user avatar
Nicholas Lewis
user avatar
Emiliano Balbuena
Reference: minds/front#1916