Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 808
  • Merge Requests 53
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !629

Merged
Opened 3 days ago by Guy Thouret@gthouret
Report abuse

Fix duplicate boost posts appearing in newfeed

Steps to recreate:

  • Start a new session on live site
  • Scroll down newsfeed
  • The same boost will repeat in the first 3/4 boost slots of the newsfeed (not including the boost rotator)

Expected Behaviour:

  • The boosts should be rendered sequentially as they were returned in the feed request
Edited 3 hours ago by Guy Thouret
Request to merge fix/2190-boost-feed into master
Pipeline #94355594 passed with warnings for b9432ffb on fix/2190-boost-feed
              Merge request approved. Approved by
              Xander Miller
              Xander Miller
              Emiliano Balbuena
              Emiliano Balbuena
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet

              Merged by Xander Miller 2 hours ago

              The changes were merged into master with 7d5d6f16

              The source branch has been deleted

              Closed #2190 (closed)

              Pipeline #94387756 waiting for manual action for 7d5d6f16 on master
                            • Discussion 1
                            • Commits 1
                            • Pipelines 8
                            • Changes 4
                            • Guy Thouret @gthouret added MR::Requires Changes Priority::1 - High Product::Boost Sprint::10/23 - Quiet Quail Squad::Blue scoped labels 3 days ago

                              added scoped labels

                            • Guy Thouret
                              Guy Thouret @gthouret · 3 days ago
                              Developer

                              https://stackblitz.com/edit/test-boost-feed-code

                            • Guy Thouret @gthouret added 1 commit 2 days ago

                              added 1 commit

                              • 9bc02079 - (fix) Prevent feed offset from exceeding the maximum offset of the filtered...

                              Compare with previous version

                            • Guy Thouret @gthouret added 4 commits 2 days ago

                              added 4 commits

                              • af79b04d - (chore) Remove unused imports from EntitiesService - #2190 (closed)
                              • 5ae4efa5 - (chore) Remove unused imports from BlockListService - #2190 (closed)
                              • c4b81ad8 - (chore) Remove unused imports / types from FeedService - #2190 (closed)
                              • f0fef876 - (chore) Improve debug output and add a retry if empty feed data in FeaturedContentService - #2190 (closed)

                              Compare with previous version

                              Toggle commit list
                            • Guy Thouret @gthouret added 32 commits 2 days ago

                              added 32 commits

                              • f0fef876...8e222112 - 31 commits from branch master
                              • d608876c - Merge branch 'master' into fix/2190-boost-feed

                              Compare with previous version

                            • Guy Thouret @gthouret added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 day ago

                              added scoped label and automatically removed label

                            • Guy Thouret @gthouret added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 day ago

                              added scoped label and automatically removed label

                            • Guy Thouret @gthouret added 1 commit 1 day ago

                              added 1 commit

                              • 605b1b40 - (fix) Move the increment and test of offset inside the async pipe in FeaturedContentService - #2190 (closed)

                              Compare with previous version

                            • Guy Thouret @gthouret added 1 commit 6 hours ago

                              added 1 commit

                              • 46e4e01f - (fix) Increment on each fetch call, only test for offset reset and fetch next...

                              Compare with previous version

                            • Guy Thouret @gthouret added 22 commits 4 hours ago

                              added 22 commits

                              • 46e4e01f...6d0095f2 - 21 commits from branch master
                              • b9432ffb - (fix) Tidy feed code and prevent featured content service from exceeding...

                              Compare with previous version

                            • Guy Thouret @gthouret unmarked as a Work In Progress 4 hours ago

                              unmarked as a Work In Progress

                            • Guy Thouret @gthouret changed the description 4 hours ago

                              changed the description

                            • Guy Thouret @gthouret added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 4 hours ago

                              added scoped label and automatically removed label

                            • Guy Thouret @gthouret changed the description 3 hours ago

                              changed the description

                            • Emiliano Balbuena @edgebal approved this merge request 3 hours ago

                              approved this merge request

                            • Xander Miller @xander-miller approved this merge request 2 hours ago

                              approved this merge request

                            • Xander Miller @xander-miller mentioned in commit 7d5d6f16 2 hours ago

                              mentioned in commit 7d5d6f16

                            • Xander Miller @xander-miller merged 2 hours ago

                              merged

                            Please register or sign in to reply
                            0 Assignees
                            None
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            5
                            Labels
                            MR::Awaiting Review Priority::1 - High Product::Boost Sprint::10/23 - Quiet Quail Squad::Blue
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Juan Manuel Solaro
                            user avatar
                            Ben Hayward
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Mark Harding
                            user avatar
                            Brian Hatchet
                            user avatar
                            Olivia Madrid
                            user avatar
                            Martin Santangelo
                            Reference: minds/front!629