Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 808
  • Merge Requests 53
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !631

Open
Opened 1 day ago by Emiliano Balbuena@edgebal
Report abuse

(feat): Show "log in to comment" when logged out

Testing

Empty comments box

  • Create a new post in the newsfeed and copy the URL
  • Log out and paste the URL
  • A Log in to comment link should show up
  • Click on LOGIN and enter creds
  • Page will be refreshed and comment composer should show up

Threaded comments box

  • (using the post from the previous testing case)
  • Add a comment
  • Reply to that same comment to create a thread
  • Log out and paste the URL
  • A Log in to comment link should show up on the root level
  • Nothing should show up on the thread
  • Click on LOGIN and enter creds
  • Page will be refreshed and comment composer should show up on both root and thread levels

Group conversation

  • Create (or go to) a public group, copy the URL
  • Logout and paste the URL
  • A Log in to send a message link should show up
  • Click on LOGIN and enter creds
  • Page will be refreshed and message composer should show up

Issues

  • Closes #2052.
Request to merge goal/log-in-notice-comment-thread into master
The source branch is 5 commits behind the target branch
Open in Web IDE
Pipeline #94347466 passed with warnings for 266bb434 on goal/log-in-notice-comment-thread
              Requires 2 more approvals from Devs and Deployers. Approved by
              Xander Miller
              Xander Miller
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2052

              Deletes source branch

              • Discussion 2
              • Commits 3
              • Pipelines 2
              • Changes 7
              • Emiliano Balbuena @edgebal added Sprint::10/23 - Quiet Quail scoped label 1 day ago

                added scoped label

              • Mark Harding @markeharding added MR::Ready to Merge scoped label 4 hours ago

                added scoped label

              • Mark Harding @markeharding approved this merge request 4 hours ago

                approved this merge request

              • Mark Harding @markeharding assigned to @ottman, @jotto141, and @xander-miller 4 hours ago

                assigned to @ottman, @jotto141, and @xander-miller

              • Mark Harding @markeharding unapproved this merge request 4 hours ago

                unapproved this merge request

              • Mark Harding
                Mark Harding @markeharding · 4 hours ago
                Owner

                @edgebal When clicking from a modal, the login modal shows behind the media modal.

              • Emiliano Balbuena @edgebal added 21 commits 2 hours ago

                added 21 commits

                • 34c3727b...b8faccdb - 19 commits from branch master
                • f43130b5 - Merge remote-tracking branch 'origin/master' into goal/log-in-notice-comment-thread
                • 266bb434 - (fix): Modal z-index on minds.com; stop click bubbling

                Compare with previous version

              • Xander Miller @xander-miller approved this merge request 18 minutes ago

                approved this merge request

              • Xander Miller
                Xander Miller @xander-miller · 15 minutes ago
                Developer

                Thanks for the concise testing instructions @edgebal very useful. :100:

              Please register or sign in to reply
              4 Assignees
              Emiliano Balbuena's avatar
              Bill Ottman's avatar
              Jack Ottman's avatar
              Xander Miller's avatar
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Ready to Merge Sprint::10/23 - Quiet Quail
              Lock merge request
              Unlocked
              12
              12 participants
              user avatar
              Juan Manuel Solaro
              user avatar
              Ben Hayward
              user avatar
              Marcelo Rivera
              user avatar
              Guy Thouret
              user avatar
              Mark Harding
              user avatar
              Brian Hatchet
              user avatar
              Olivia Madrid
              Reference: minds/front!631