Next

Is this a bug? Make sure to use the Bug template above and be as detailed in your report as possible.

added scoped label

assigned to @gthouret

added scoped label

added scoped label

added scoped label

We ignore the offset requested from the iterator and instead override with the timestamp of the last boost in list with no explanation why we don't trust the iterator This is part of feed class not iterator

• Iterator makes a request for X boosts, if Y of those boosts are invalid or can not be resolved the iterator will return X - Y boosts, requiring additional requests to cycle the iterator (which could return few or no results again)

hydrate set in the iterator makes the iterator fetch the entity and compare it's impressions value with the boost impressions value to determine if the boost has finished.

• It's called an Iterator, I am not expecting an iterator to contain this functionality, how could I have known this functionality is hidden away here, not to mention this is pretty inefficient within an API call.

In the hydrate functionality if we determine a boost has finished we call Expire::expire() which changes the boost state to complete and generates event and notification.

• Seems overkill for this one method to have it's own class, feels like it should be a part of Manager functionality

The increment option is used within hydrate to call Metrics::incrementViews() that increments some values in counters db table.

• Metrics references a Mongo database which AFAIK as been abandoned/decommissioned

• In Iterator hydrate and increment flag functionality are mutually exclusive where as the code has them nested that implies some sort of dependency. i.e. We can't increment without hydrating which is not true.

• Boost\Network\Iterator class has no spec test coverage.

mentioned in issue #1038

added scoped label and automatically removed label

changed time estimate to 6h

changed weight to 2

• ManagerSpec is failing

mentioned in commit ae5588a3

mentioned in commit 9811f66e

marked this issue as related to #1078 (closed)

changed time estimate to 1d 4h

added 6h of time spent at 2019-11-04

Added time to wrong ticket

changed time estimate to 4h

added 2h of time spent at 2019-11-04

added scoped label and automatically removed label

mentioned in epic &73

changed time estimate to 1d

• Check feed sync=1 flag passing to hydrate is resolved

Original comment: sync=1 is used by the /fetch API which in sets a sync flag which sets a hydrate flag in the iterator.

added to epic &103