Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 808
  • Merge Requests 54
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !625

Open
Opened 6 days ago by Marcelo Rivera@eiennohi
Report abuse

Wire button skewed on pro media page

closes #2187 closes #2206

Edited 1 day ago by Marcelo Rivera
Request to merge fix/wire-button-2187 into master
The source branch is 50 commits behind the target branch
Open in Web IDE
Pipeline #93902239 passed with warnings for cb25998d on fix/wire-button-2187
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena
              Emiliano Balbuena
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #2187 and #2206

              Deletes source branch

              • Discussion 2
              • Commits 3
              • Pipelines 2
              • Changes 2
              0/2 threads resolved
              • Marcelo Rivera @eiennohi changed milestone to %Pro Beta #release 6 days ago

                changed milestone to %Pro Beta #release

              • Marcelo Rivera @eiennohi added Squad::Yellow scoped label 6 days ago

                added scoped label

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 3 days ago
                Last updated by Marcelo Rivera 1 day ago
                src/app/modules/wire/button/button.component.scss
                4 4 border: 0;
                5 5 border-radius: 0;
                6 6 */
                7 display: flex;
                • Mark Harding
                  Mark Harding @markeharding · 3 days ago
                  Owner

                  Do we really need to use flex?

                • Marcelo Rivera @eiennohi changed this line in version 2 of the diff 1 day ago

                  changed this line in version 2 of the diff

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label 3 days ago

                added scoped label

              • Marcelo Rivera @eiennohi added 1 commit 1 day ago

                added 1 commit

                • cb25998d - (fix): remove flexbox

                Compare with previous version

              • Marcelo Rivera @eiennohi mentioned in issue #2206 1 day ago

                mentioned in issue #2206

              • Marcelo Rivera @eiennohi changed the description 1 day ago

                changed the description

              • Marcelo Rivera @eiennohi added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 day ago

                added scoped label and automatically removed label

              • Mark Harding
                Mark Harding @markeharding started a thread on the diff 1 hour ago
                src/app/modules/wire/button/button.component.scss
                21 20 > .ion-icon {
                22 21 // transform: scale(1.6);
                23 22 font-size: 18px;
                23 vertical-align: middle;
                24 24 }
                25 25
                26 26 span {
                27 27 margin-left: $minds-margin;
                28 28 vertical-align: middle;
                29 line-height: 21px;
                • Mark Harding
                  Mark Harding @markeharding · 1 hour ago
                  Owner

                  why is this 21px?

                  With 21px

                  Screen_Shot_2019-11-07_at_11.08.08_AM

                  Without 21px

                  Screen_Shot_2019-11-07_at_11.08.13_AM

                • Please register or sign in to reply
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 hour ago

                added scoped label and automatically removed label

              Please register or sign in to reply
              0 Assignees
              None
              Pro Beta #release
              Milestone
              Pro Beta #release
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Ben Hayward
              user avatar
              Emiliano Balbuena
              user avatar
              Guy Thouret
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              user avatar
              Brian Hatchet
              user avatar
              Olivia Madrid
              Reference: minds/front!625