Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project overview
  • Repository
  • Issues 808
  • Merge Requests 54
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !620

Merged
Opened 1 week ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/QuietQuail](fix): Adjusted padded element to prevent misclicks. #2114

Testing

Try click around the edges of the dropdown

image

Request to merge fix/dropdown-padding-2114 into master
Pipeline #93866547 passed with warnings for fe50474d on fix/dropdown-padding-2114
              Merge request approved. Approved by
              Mark Harding
              Mark Harding
              Emiliano Balbuena
              Emiliano Balbuena
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller

              Merged by Mark Harding 43 minutes ago

              The changes were merged into master with 995ea4c1

              The source branch has been deleted

              Mentions #2114

              Pipeline #94319211 running for 995ea4c1 on master
                            • Discussion 2
                            • Commits 4
                            • Pipelines 4
                            • Changes 2
                            0/2 threads resolved
                            • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 week ago

                              added scoped labels

                            • Ben Hayward @benhayward.ben added 1 commit 1 week ago

                              added 1 commit

                              • a4c3da15 - Fixed light option

                              Compare with previous version

                            • Ben Hayward @benhayward.ben mentioned in issue #2138 (closed) 3 days ago

                              mentioned in issue #2138 (closed)

                            • Mark Harding
                              Mark Harding @markeharding started a thread on an old version of the diff 3 days ago
                              Last updated by Ben Hayward 1 day ago
                              src/app/common/components/dropdown/dropdown.component.scss
                              94 95
                              95 96 .m-dropdown--list--item,
                              96 97 .m-dropdownList__item {
                              97 padding: 8px;
                              98 98 @include m-theme() {
                              99 99 border-bottom: 1px solid themed($m-grey-50);
                              100 100 }
                              101 101
                              102 a,
                              • Mark Harding
                                Mark Harding @markeharding · 3 days ago
                                Owner

                                perhaps just use > * incase it is not either a a or div (could be span etc).

                              • Ben Hayward @benhayward.ben changed this line in version 4 of the diff 1 day ago

                                changed this line in version 4 of the diff

                              • Please register or sign in to reply
                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 3 days ago

                              added scoped label and automatically removed label

                            • Ben Hayward @benhayward.ben added 1 commit 3 days ago

                              added 1 commit

                              • 032c314c - Updated to catch future additions

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 3 days ago

                              added scoped label and automatically removed label

                            • Ben Hayward @benhayward.ben resolved all threads 3 days ago

                              resolved all threads

                            • Mark Harding
                              Mark Harding @markeharding started a thread on an old version of the diff 2 days ago
                              Last updated by Ben Hayward 1 day ago
                              src/app/common/components/dropdown/dropdown.component.scss
                              94 94
                              95 95 .m-dropdown--list--item,
                              96 96 .m-dropdownList__item {
                              97 padding: 8px;
                              98 97 @include m-theme() {
                              99 98 border-bottom: 1px solid themed($m-grey-50);
                              100 99 }
                              101 100
                              101 a,
                              • Mark Harding
                                Mark Harding @markeharding · 2 days ago
                                Owner

                                @benhayward.ben still missing this one

                              • Ben Hayward @benhayward.ben changed this line in version 4 of the diff 1 day ago

                                changed this line in version 4 of the diff

                              • Please register or sign in to reply
                            • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 2 days ago

                              added scoped label and automatically removed label

                            • Ben Hayward @benhayward.ben added 1 commit 1 day ago

                              added 1 commit

                              • fe50474d - Added in less specific selector

                              Compare with previous version

                            • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 day ago

                              added scoped label and automatically removed label

                            • Mark Harding @markeharding approved this merge request 43 minutes ago

                              approved this merge request

                            • Mark Harding @markeharding merged 43 minutes ago

                              merged

                            • Mark Harding @markeharding mentioned in commit 995ea4c1 43 minutes ago

                              mentioned in commit 995ea4c1

                            Please register or sign in to reply
                            0 Assignees
                            None
                            None
                            Milestone
                            None
                            Time tracking
                            No estimate or time spent
                            2
                            Labels
                            MR::Awaiting Review Squad::Yellow
                            Lock merge request
                            Unlocked
                            10
                            10 participants
                            user avatar
                            Emiliano Balbuena
                            user avatar
                            Marcelo Rivera
                            user avatar
                            Guy Thouret
                            user avatar
                            Martin Santangelo
                            user avatar
                            Brian Hatchet
                            user avatar
                            Olivia Madrid
                            user avatar
                            Juan Manuel Solaro
                            Reference: minds/front!620