[Sprint/InterestingIguana](feat): Preferred hashtag remembered in local storage #1366
Closes #1302 (closed)
Test that your selection for preferred is remembered in local storage.
- Set it to on
- Tab over to wallet or another page
- Refresh
- Visit discovery - it should have remembered the state was on.
- Turn it off, and repeat to confirm that is remembers the 'off' state
Closed by
The changes were not merged into master
approved this merge request
![Mark Harding](data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="200" height="200"><rect fill-opacity="0"/></svg>)
Owner
allis not being set on the API. The button may be saving but you need to toggle on/off to get the list component to realise.added scoped label
- Developer
Okay, I see what you mean. added that in.
- Resolved by Ben Hayward
added 1 commit
- 04c502a3 - Emit event on load to set querystring properly
resolved all threads
added scoped label and automatically removed label
added scoped label
added 217 commits
-
04c502a3...d69d2bd0 - 216 commits from branch
master - 92f471ca - Merge branch 'master' of gitlab.com:minds/front into fix/default-preferred-state-1366
-
04c502a3...d69d2bd0 - 216 commits from branch
changed title from [Sprint/InterestingIguana] Preferred hashtag remembered in local storage to [Sprint/InterestingIguana] Preferred hashtag remembered in local storage
changed the description
added scoped label and automatically removed label
- Developer
Not working correctly.
Steps to reproduce faulty behaviour:
- Turn off preferred in discovery. (This saves the cookie to the off state).
- Click over to another page (do not reload)
- Go back to discovery - preferred will be switched on when it should not be.
added 1 commit
- 306c6330 - Removed line causing undesired preferred tag emission.
added scoped label and automatically removed label
- Developer
This was caused by
src/app/modules/newsfeed/newsfeed.component.htmltrying to set the value of preferred via the input. added 112 commits
-
306c6330...534f449e - 111 commits from branch
master - 4e6864e1 - Merge branch 'master' of gitlab.com:minds/front into fix/default-preferred-state-1366
-
306c6330...534f449e - 111 commits from branch
added 49 commits
-
4e6864e1...2647cd27 - 47 commits from branch
master - 40a4c517 - Merge branch 'master' of gitlab.com:minds/front into fix/default-preferred-state-1366
- cc971618 - Linted
-
4e6864e1...2647cd27 - 47 commits from branch
- Owner
Note how two calls are made, one with
all=and one withall=1. Only one call should be made here.
added scoped label and automatically removed label
added 55 commits
-
abfff287...9bd84a18 - 52 commits from branch
master - 4449fcfd - Only run on secondary emission.
- fcd3c5ff - Merge branch 'master' of gitlab.com:minds/front into fix/default-preferred-state-1366
- 2d27e664 - Merge branch 'fix/default-preferred-state-1366' of gitlab.com:minds/front into...
Toggle commit list-
abfff287...9bd84a18 - 52 commits from branch
closed
