Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 294
  • Merge Requests 37
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !376

Merged
Opened 2 weeks ago by Guy Thouret@gthouret
Report abuse

Upgrade to PHP 7.3

Updates to Dockerfiles and app changes for deprecations / usages that are new since 7.1

Edited 1 day ago by Guy Thouret
Request to merge chore/665-refactor-object-use into master
Pipeline #93907763 passed for 4fc0217a on chore/665-refactor-object-use
          Merge request approved. Approved by
          Mark Harding
          Mark Harding
          Marcelo Rivera
          Marcelo Rivera
          Martin Santangelo
          Martin Santangelo
          Ben Hayward
          Ben Hayward
          Rami Albatal
          Rami Albatal
          Emiliano Balbuena
          Emiliano Balbuena

          Merged by Mark Harding 1 hour ago

          The changes were merged into master with 8c0117e5

          The source branch has been deleted

          Closed #1065 (closed)

          Pipeline #94017566 failed for 8c0117e5 on master
                        • Discussion 2
                        • Commits 39
                        • Pipelines 26
                        • Changes 147
                        • Guy Thouret @gthouret added MR::Awaiting Review Product::Platform Sprint::10/09 - Pink Panther Squad::Blue Type::Chore scoped labels 2 weeks ago

                          added scoped labels

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • c0543c8a - (chore) Update gitlab-ci to use minds/php:7.3 image - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 3 commits 2 weeks ago

                          added 3 commits

                          • 3bc76f13 - (chore) Fix broken spec test for Core\Analytics\Views\Repository - #665 (closed)
                          • 3124d71b - (chore) Alter Core\Analytics\Views\Repository because Mock Timeuuid returns...
                          • b476aabb - (chore) Don't load extensions at test stage so that mocks are used and tests pass - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • 68f9299a - (chore) Enable minimal set of extensions when running Spec tests - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • 0df606ec - (chore) Tag my build cache to prevent collisions with other builds; Only start...

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • 7daa1cd1 - (chore) Minor typo in CI cache key - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • a1d23a09 - (chore) Distributed runners require pull/push cache policy - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • 3b7f4b85 - (chore) Use artifacts instead of cache - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • a98f865e - (fix) Force php-cs-fixer to run under unsupported php version - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • d2175fb1 - (fix) Use minds/php:7.3 for all container builds in the ci - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • 05765739 - (fix) Don't reinstall opcache during php-fpm container build + reduce number of layers - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • 39e171f7 - (fix) Reduce build time by replacing docker-php-ext-enable command for opcache - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 2 weeks ago

                          added 1 commit

                          • 43952cf5 - (fix) Resolve composer dependency hell to get necessary upgrades to packages - #665 (closed)

                          Compare with previous version

                        • Guy Thouret @gthouret added 2 commits 1 week ago

                          added 2 commits

                          • 6d172704 - (chore) No references to MultiSiteDomain - removing #665 (closed)
                          • 3ecd9b37 - (chore) Remove braintree as update is required and API has changes that would...

                          Compare with previous version

                        • Guy Thouret @gthouret added 3 commits 1 week ago

                          added 3 commits

                          • 1a69e400 - (chore) Add sockets extension to PHP 7.3 container - Fixes #1065 (closed)
                          • 2035b9b4 - (chore) Payments\Factory - Remove inaccurate docblocks - #1066
                          • 05b05063 - (chore) Update Braintree usage so tests pass - #1066

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 1 week ago

                          added 1 commit

                          • 6ce01682 - (chore) Remove braintree package and referencing code; Replace abandoned...

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 1 week ago

                          added 1 commit

                          • 5505196f - (chore) Remove awscli from php container as it adds 100MB+ of python...

                          Compare with previous version

                        • Guy Thouret @gthouret added 1 commit 1 week ago

                          added 1 commit

                          • 90fd26d0 - (chore) Linting after upgrading php-cs-fixer - #1072

                          Compare with previous version

                        • Guy Thouret @gthouret added 2 commits 1 week ago

                          added 2 commits

                          • 6d26d56a - (chore) Load sockets extension when running tests - #1065 (closed)
                          • e996f15f - (chore) Linting after upgrading php-cs-fixer - #1072

                          Compare with previous version

                        • Guy Thouret @gthouret added 47 commits 1 day ago

                          added 47 commits

                          • e996f15f...8a5e4d6a - 46 commits from branch master
                          • 95e7647e - Merge branch 'master' into chore/665-refactor-object-use

                          Compare with previous version

                        • Guy Thouret @gthouret unmarked as a Work In Progress 1 day ago

                          unmarked as a Work In Progress

                        • Guy Thouret @gthouret added 1 commit 1 day ago

                          added 1 commit

                          • 6052b851 - (chore) Linting after merging master - #1072

                          Compare with previous version

                        • Mark Harding
                          Mark Harding @markeharding · 18 hours ago
                          Owner

                          @gthouret can you fix the merge conflicts?

                        • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 18 hours ago

                          added scoped label and automatically removed label

                        • Guy Thouret @gthouret added 3 commits 14 hours ago

                          added 3 commits

                          • 6052b851...af77626a - 2 commits from branch master
                          • 4fc0217a - Merge branch 'master' into chore/665-refactor-object-use

                          Compare with previous version

                        • Guy Thouret
                          Guy Thouret @gthouret · 14 hours ago
                          Developer

                          @markeharding Literally resolved conflicts hours before that, resolved again.

                          There were some more linting rules introduced with the php-cs-fixer upgrade so potential for conflict is fairly high I guess.

                        • Guy Thouret @gthouret added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 14 hours ago

                          added scoped label and automatically removed label

                        • Mark Harding @markeharding approved this merge request 1 hour ago

                          approved this merge request

                        • Mark Harding @markeharding mentioned in commit 8c0117e5 1 hour ago

                          mentioned in commit 8c0117e5

                        • Mark Harding @markeharding merged 1 hour ago

                          merged

                        Please register or sign in to reply
                        0 Assignees
                        None
                        None
                        Milestone
                        None
                        Time tracking
                        No estimate or time spent
                        5
                        Labels
                        MR::Awaiting Review Product::Platform Sprint::10/09 - Pink Panther Squad::Blue Type::Chore
                        Lock merge request
                        Unlocked
                        10
                        10 participants
                        user avatar
                        Marcelo Rivera
                        user avatar
                        Martin Santangelo
                        user avatar
                        Ben Hayward
                        user avatar
                        Rami Albatal
                        user avatar
                        Emiliano Balbuena
                        user avatar
                        Brian Hatchet
                        user avatar
                        Olivia Madrid
                        Reference: minds/engine!376