Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project overview
  • Repository
  • Issues 291
  • Merge Requests 38
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !388

Open
Opened 1 day ago by Marcelo Rivera@eiennohi
Report abuse

Remove asset signing for public posts

#914

Request to merge fix/remove-public-asset-signing into master
The source branch is 7 commits behind the target branch
Open in Web IDE
Pipeline #93553893 passed for 3c748de9 on fix/remove-public-asset-signing
          Requires 3 more approvals from Devs, Deployers, and QA.
          Rami Albatal
          Rami Albatal
          Martin Santangelo
          Martin Santangelo
          Emiliano Balbuena
          Emiliano Balbuena
          Mark Harding
          Mark Harding
          Olivia Madrid
          Olivia Madrid
          Ready to be merged automatically. Ask someone with write access to this repository to merge this request

          Mentions #914

          Deletes source branch

          • Discussion 8
          • Commits 3
          • Pipelines 4
          • Changes 7
          5/6 threads resolved
          • Marcelo Rivera @eiennohi added Squad::Yellow scoped label 1 day ago

            added scoped label

          • Marcelo Rivera @eiennohi added 1 commit 1 day ago

            added 1 commit

            • 2a395c1d - (fix): spec tests

            Compare with previous version

          • Marcelo Rivera @eiennohi added 1 commit 1 day ago

            added 1 commit

            • cba0d53b - (fix): spec tests

            Compare with previous version

          • Marcelo Rivera
            Marcelo Rivera @eiennohi · 1 day ago
            Developer

            tested with both public newsfeed and closed group activities

          • Marcelo Rivera @eiennohi added 1 commit 1 day ago

            added 1 commit

            • 3c748de9 - (fix): spec tests

            Compare with previous version

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 day ago
            Resolved by Marcelo Rivera 9 minutes ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 day ago
            Resolved by Marcelo Rivera 6 minutes ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 day ago
            Resolved by Marcelo Rivera 5 minutes ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 day ago
            Resolved by Marcelo Rivera 5 minutes ago
          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 day ago
            Core/Media/Thumbnails.php
            15 15 $this->config = $config ?: Di::_()->get('Config');
            16 16 }
            17 17
            18 public function get($guid, $size)
            18 /**
            19 * @param $entity Entities\Entity|string
            20 * @param $size
            21 * @return bool|\ElggFile|mixed|string
            22 */
            23 public function get($entity, $size)
            19 24 {
            20 $entity = Entities\Factory::build($guid);
            25 if (is_string($entity)) {
            26 $entity = Entities\Factory::build($entity);
            • Mark Harding
              Mark Harding @markeharding · 1 day ago
              Owner

              Can we use entitiesBuilder for spec test sanity?

            • Please register or sign in to reply
          • Mark Harding @markeharding added MR::Requires Changes scoped label 1 day ago

            added scoped label

          • Mark Harding
            Mark Harding @markeharding started a thread on the diff 1 day ago
            Resolved by Marcelo Rivera 4 minutes ago
          Please register or sign in to reply
          0 Assignees
          None
          None
          Milestone
          None
          Time tracking
          No estimate or time spent
          2
          Labels
          MR::Requires Changes Squad::Yellow
          Lock merge request
          Unlocked
          10
          10 participants
          user avatar
          Rami Albatal
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Olivia Madrid
          user avatar
          Ben Hayward
          user avatar
          Guy Thouret
          Reference: minds/engine!388