Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
  • Repository
  • Issues 802
  • Merge Requests 51
  • CI / CD
  • Security & Compliance
  • Packages
  • Wiki
  • Snippets
  • Members
  • Collapse sidebar
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !628

Open
Opened 1 day ago by Ben Hayward@benhayward.ben
Report abuse

[Sprint/QuietQuail](fix): Avatar changing forms now change avatar without refresh of components

Closes #2197 #2087 #1835 and half of #2082

Testing

I think it'd be best to spin this up on a subdomain connected to live data, like revolver; so that it can be tested on the live site.

This makes changes to avatars site-wide, user avatars, and group avatars.

To test:

  1. Create a new account.
  2. Upload an avatar - check it updates everywhere.
  3. Create a comment on a post with current avatar.
  4. Change avatar.
  5. Create a second comment on a post, avatar on all comments should match current avatar of channel.
Edited 1 hour ago by Xander Miller
Request to merge fix/avatar-change-detection-2197 into master
The source branch is 33 commits behind the target branch
Open in Web IDE
Pipeline #93466360 passed with warnings for f5118c96 on fix/avatar-change-detection-2197
              Requires 3 more approvals from Devs, Deployers, and QA.
              Emiliano Balbuena
              Emiliano Balbuena
              Mark Harding
              Mark Harding
              Brian Hatchet
              Brian Hatchet
              Xander Miller
              Xander Miller
              Ready to be merged automatically. Ask someone with write access to this repository to merge this request

              Closes #1835, #2087, and #2197

              Mentions #2082

              Deletes source branch

              • Discussion 5
              • Commits 4
              • Pipelines 4
              • Changes 3
              1/1 thread resolved
              • Ben Hayward @benhayward.ben added MR::Awaiting Review Squad::Yellow scoped labels 1 day ago

                added scoped labels

              • Ben Hayward @benhayward.ben added 1 commit 1 day ago

                added 1 commit

                • 631d2347 - Added docs and removed an unused import.

                Compare with previous version

              • Ben Hayward @benhayward.ben changed the description 1 day ago

                changed the description

              • Ben Hayward @benhayward.ben added 1 commit 1 day ago

                added 1 commit

                • 908ebf3f - Changed service encapsulation for use in template

                Compare with previous version

              • Mark Harding
                Mark Harding @markeharding started a thread on an old version of the diff 1 day ago
                Resolved by Ben Hayward 1 day ago
              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 1 day ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben added 1 commit 1 day ago

                added 1 commit

                • f5118c96 - Refactored and got rid of account switching bug

                Compare with previous version

              • Ben Hayward @benhayward.ben added MR::Awaiting Review scoped label and automatically removed MR::Requires Changes label 1 day ago

                added scoped label and automatically removed label

              • Ben Hayward @benhayward.ben resolved all threads 1 day ago

                resolved all threads

              • Ben Hayward @benhayward.ben resolved all threads 1 day ago

                resolved all threads

              • Mark Harding
                Mark Harding @markeharding · 7 hours ago
                Owner

                After login, I no longer have an avatar on the topbar Screenshot_2019-11-05_at_10.05.47.

              • Mark Harding @markeharding added MR::Requires Changes scoped label and automatically removed MR::Awaiting Review label 7 hours ago

                added scoped label and automatically removed label

              • Mark Harding
                Mark Harding @markeharding · 7 hours ago
                Owner

                Appears to be a change detection issue.

              • Xander Miller @xander-miller mentioned in merge request engine!386 (merged) 1 hour ago

                mentioned in merge request engine!386 (merged)

              • Xander Miller
                Xander Miller @xander-miller · 1 hour ago
                Developer

                Comment avatars should match current avatar not avatar when comment was made.

                image

              • Xander Miller @xander-miller changed the description 1 hour ago

                changed the description

              Please register or sign in to reply
              0 Assignees
              None
              None
              Milestone
              None
              Time tracking
              No estimate or time spent
              2
              Labels
              MR::Requires Changes Squad::Yellow
              Lock merge request
              Unlocked
              10
              10 participants
              user avatar
              Juan Manuel Solaro
              user avatar
              Emiliano Balbuena
              user avatar
              Marcelo Rivera
              user avatar
              Olivia Madrid
              user avatar
              Mark Harding
              user avatar
              Martin Santangelo
              user avatar
              Guy Thouret
              Reference: minds/front!628