Next

Closes #907

Summary

On production, if you upload a gif as your avatar, 2 things:

1. The resize is broken. If you take the image URL and change between large and small, there is no difference.
2. The GIF will not be cropped, so if it's wide or long, it will be malformed in older areas like "create new blog".
3. The GIF will likely appear as a quite a glitchy still-frame. (it should be a still-frame but not glitchy)

Prod

Testing

Firstly, I recommend you grab a testing gif. I used the following.

Try setting that as your avatar on production to see the issue, also head over to 'Create Blog' which is an older page that does not have front-end validation to stop the image from covering an extra-wide space.

For testing, try it on a sandbox, check all the places your avatar will be. Post it a few places and make sure the gif isn't messed with and image files can all still be uploaded fine around the site. I could not find any outliers where this did not cover it.

Sandbox

added scoped labels

Because the sizes were broken on prod, I think the blog section is using a small image when it should be using a medium. This might require a quick change in addition to this to sharpen it.

added 1 commit

• 357e54c4 - Linted

Compare with previous version

added scoped label and automatically removed label

@xander-miller please give approval when a happy

approved this merge request

assigned to @xander-miller

I used my own gif image.

Requirements need a bit more clarification.

• Gif is correctly resized.
• Gif is correctly cropped.

However, on hard refresh gif is not animated and while avatar on old posts updates, old comments continue to use previous avatar.

It meets the criteria set out in the issue but we should know if old comment avatars should update and whether we permit animated avatars.

1. Animated avatars are not allowed.
2. Comment avatar is avatar when comment created while post avatar is the current channel avatar. This will be addressed in front!628

approved this merge request